From: Stefan Wahren <stefan.wahren@i2se.com>
To: Stefan Wahren <wahrenst@gmx.net>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <swboyd@chromium.org>
Cc: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>,
iommu@lists.linux-foundation.org,
Ian Jackson <ian.jackson@citrix.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: Build regression in Linux 5.3-rc5 with CONFIG_XEN=y
Date: Wed, 21 Aug 2019 07:55:14 +0200 [thread overview]
Message-ID: <0b4f05ab-6cc1-7805-ea99-021c2bdd41be@i2se.com> (raw)
In-Reply-To: <a69cce68-8c41-2030-b011-cdfacfeae421@gmx.net>
Hi Bjorn,
hi Stephen,
Am 20.08.19 um 07:43 schrieb Stefan Wahren:
> Hi Christoph,
>
> Am 20.08.19 um 03:24 schrieb Christoph Hellwig:
>> Hi Stefan,
>>
>> please try the patch below.
>>
>> ---
>> From e0570628d96faa50ebfc94ce8e545968336db225 Mon Sep 17 00:00:00 2001
>> From: Christoph Hellwig <hch@lst.de>
>> Date: Tue, 20 Aug 2019 10:08:38 +0900
>> Subject: arm: select the dma-noncoherent symbols for all swiotlb builds
>>
>> We need to provide the arch hooks for non-coherent dma-direct
>> and swiotlb for all swiotlb builds, not just when LPAS is enabled.
> s/LPAS/LPAE/
>> Without that the Xen build that selects SWIOTLB indirectly through
>> SWIOTLB_XEN fails to build.
>>
>> Fixes: ad3c7b18c5b3 ("arm: use swiotlb for bounce buffering on LPAE configs")
>> Reported-by: Stefan Wahren <wahrenst@gmx.net>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
> i applied this patch and it fixes the build issue i reported before. But
> this seems to reveal another build issue in drivers/firmware/qcom_scm.c:
>
> drivers/firmware/qcom_scm.c: In function ‘qcom_scm_assign_mem’:
> drivers/firmware/qcom_scm.c:460:47: error: passing argument 3 of
> ‘dma_alloc_coherent’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> ptr = dma_alloc_coherent(__scm->dev, ptr_sz, &ptr_phys, GFP_KERNEL);
> ^
> In file included from drivers/firmware/qcom_scm.c:12:0:
> ./include/linux/dma-mapping.h:636:21: note: expected ‘dma_addr_t * {aka
> long long unsigned int *}’ but argument is of type ‘phys_addr_t * {aka
> unsigned int *}’
> static inline void *dma_alloc_coherent(struct device *dev, size_t size,
> ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> scripts/Makefile.build:280: die Regel für Ziel
> „drivers/firmware/qcom_scm.o“ scheiterte
>
> Luckily there is already a patch to fix this in linux-next:
>
> firmware: qcom_scm: Use proper types for dma mappings
could you please take care that this patch is applied to 5.3-fixes?
>
> It seems that it misses the fixes tag.
>
> Regards
> Stefan
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-08-21 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 18:37 Build regression in Linux 5.3-rc5 with CONFIG_XEN=y Stefan Wahren
2019-08-19 19:02 ` Robin Murphy
2019-08-19 19:12 ` Stefan Wahren
2019-08-20 1:24 ` Christoph Hellwig
2019-08-20 5:43 ` Stefan Wahren
2019-08-20 5:46 ` Christoph Hellwig
2019-08-21 5:55 ` Stefan Wahren [this message]
2019-08-21 5:56 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4f05ab-6cc1-7805-ea99-021c2bdd41be@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=akdwived@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=hch@lst.de \
--cc=ian.jackson@citrix.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=swboyd@chromium.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).