From: Lu Baolu <baolu.lu@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: alan.cox@intel.com, Stefano Stabellini <sstabellini@kernel.org>,
ashok.raj@intel.com, Jonathan Corbet <corbet@lwn.net>,
pengfei.xu@intel.com, Ingo Molnar <mingo@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
kevin.tian@intel.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
mika.westerberg@linux.intel.com, Juergen Gross <jgross@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
jacob.jun.pan@intel.com, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v5 02/10] iommu/vt-d: Use per-device dma_ops
Date: Thu, 14 Nov 2019 13:14:11 +0800 [thread overview]
Message-ID: <0ddc8aff-783a-97b9-f5cc-9e27990de278@linux.intel.com> (raw)
In-Reply-To: <20191113095353.GA5937@lst.de>
Hi Christoph,
On 11/13/19 5:53 PM, Christoph Hellwig wrote:
> On Wed, Nov 13, 2019 at 08:03:12AM +0100, Christoph Hellwig wrote:
>> Indeed. And one idea would be to lift the code in the powerpc
>> dma_iommu_ops that check a flag and use the direct ops to the generic
>> dma code and a flag in struct device. We can then switch the intel
>> iommu ops (and AMD Gart) over to it.
>
> Let me know what you think of the branch below. Only compile tested
> and booted on qemu with an emulated intel iommu:
>
> http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-bypass
>
I took a quick look at the related patches on the branch. Most of them
look good to me. But I would like to understand more about below logic.
static int intel_dma_supported(struct device *dev, u64 mask)
{
struct device_domain_info *info = dev->archdata.iommu;
int ret;
ret = dma_direct_supported(dev, mask);
if (ret < 0)
return ret;
if (!info || info == DUMMY_DEVICE_DOMAIN_INFO ||
info == DEFER_DEVICE_DOMAIN_INFO) {
dev->dma_ops_bypass = true;
} else if (info->domain == si_domain) {
if (mask < dma_direct_get_required_mask(dev)) {
dev->dma_ops_bypass = false;
intel_iommu_set_dma_domain(dev);
dev_info(dev, "32bit DMA uses non-identity mapping\n");
} else {
dev->dma_ops_bypass = true;
}
} else {
dev->dma_ops_bypass = false;
}
return 0;
}
Could you please educate me what dma_supported() is exactly for? Will
it always get called during boot? When will it be called?
In above implementation, why do we need to check dma_direct_supported()
at the beginning? And why
if (!info || info == DUMMY_DEVICE_DOMAIN_INFO ||
info == DEFER_DEVICE_DOMAIN_INFO) {
dev->dma_ops_bypass = true;
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-11-14 5:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 3:17 [PATCH v5 00/10] iommu: Bounce page for untrusted devices Lu Baolu
2019-07-25 3:17 ` [PATCH v5 01/10] iommu/vt-d: Don't switch off swiotlb if use direct dma Lu Baolu
2019-07-25 5:41 ` Christoph Hellwig
2019-07-25 3:17 ` [PATCH v5 02/10] iommu/vt-d: Use per-device dma_ops Lu Baolu
2019-07-25 5:44 ` Christoph Hellwig
2019-07-25 7:18 ` Lu Baolu
2019-07-25 11:43 ` Christoph Hellwig
2019-07-26 1:56 ` Lu Baolu
2019-11-12 7:16 ` Christoph Hellwig
2019-11-13 2:50 ` Lu Baolu
2019-11-13 7:03 ` Christoph Hellwig
2019-11-13 9:53 ` Christoph Hellwig
2019-11-14 5:14 ` Lu Baolu [this message]
2019-11-14 8:14 ` Christoph Hellwig
2019-07-25 3:17 ` [PATCH v5 03/10] iommu/vt-d: Cleanup after use per-device dma ops Lu Baolu
2019-07-25 3:17 ` [PATCH v5 04/10] PCI: Add dev_is_untrusted helper Lu Baolu
2019-07-25 5:44 ` Christoph Hellwig
2019-07-25 3:17 ` [PATCH v5 05/10] swiotlb: Split size parameter to map/unmap APIs Lu Baolu
2019-07-25 11:47 ` Christoph Hellwig
2019-07-25 3:17 ` [PATCH v5 06/10] swiotlb: Zero out bounce buffer for untrusted device Lu Baolu
2019-07-25 11:49 ` Christoph Hellwig
2019-07-26 2:21 ` Lu Baolu
2019-07-25 3:17 ` [PATCH v5 07/10] iommu: Add bounce page APIs Lu Baolu
2019-07-25 3:17 ` [PATCH v5 08/10] iommu/vt-d: Check whether device requires bounce buffer Lu Baolu
2019-07-25 3:17 ` [PATCH v5 09/10] iommu/vt-d: Add trace events for device dma map/unmap Lu Baolu
2019-07-25 12:26 ` Steven Rostedt
2019-07-26 2:24 ` Lu Baolu
2019-07-25 3:17 ` [PATCH v5 10/10] iommu/vt-d: Use bounce buffer for untrusted devices Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ddc8aff-783a-97b9-f5cc-9e27990de278@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alan.cox@intel.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgross@suse.com \
--cc=kevin.tian@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=pengfei.xu@intel.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).