Re: [PATCH v7 02/16] iommu/smmu: Report empty domain nesting info

From: Vivek Kumar Gautam <vivek.gautam@arm.com>
To: Auger Eric <eric.auger@redhat.com>, "Liu, Yi L" <yi.l.liu@intel.com>
Cc: "Sun, Yi Y" <yi.y.sun@intel.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	"Raj, Ashok" <ashok.raj@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"stefanha@gmail.com" <stefanha@gmail.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	Will Deacon <will@kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	Robin Murphy <robin.murphy@arm.com>,
	"Tian, Jun J" <jun.j.tian@intel.com>,
	"Wu, Hao" <hao.wu@intel.com>
Subject: Re: [PATCH v7 02/16] iommu/smmu: Report empty domain nesting info
Date: Fri, 12 Feb 2021 16:31:40 +0530	[thread overview]
Message-ID: <0f159062-98a3-ba9c-e40b-732520a1d1eb@arm.com> (raw)
In-Reply-To: <306e7dd2-9eb2-0ca3-6a93-7c9aa0821ce9@arm.com>

Hi Eric,

On 2/12/21 3:48 PM, Vivek Kumar Gautam wrote:
> Hi Eric,
>
>
> On 2/12/21 3:27 PM, Auger Eric wrote:
>> Hi Vivek, Yi,
>>
>> On 2/12/21 8:14 AM, Vivek Gautam wrote:
>>> Hi Yi,
>>>
>>>
>>> On Sat, Jan 23, 2021 at 2:29 PM Liu, Yi L <yi.l.liu@intel.com> wrote:
>>>>
>>>> Hi Eric,
>>>>
>>>>> From: Auger Eric <eric.auger@redhat.com>
>>>>> Sent: Tuesday, January 19, 2021 6:03 PM
>>>>>
>>>>> Hi Yi, Vivek,
>>>>>
>>>> [...]
>>>>>> I see. I think there needs a change in the code there. Should also
>>>>>> expect
>>>>>> a nesting_info returned instead of an int anymore. @Eric, how
>>>>>> about your
>>>>>> opinion?
>>>>>>
>>>>>>      domain = iommu_get_domain_for_dev(&vdev->pdev->dev);
>>>>>>      ret = iommu_domain_get_attr(domain, DOMAIN_ATTR_NESTING,
>>>>> &info);
>>>>>>      if (ret || !(info.features & IOMMU_NESTING_FEAT_PAGE_RESP)) {
>>>>>>              /*
>>>>>>               * No need go futher as no page request service support.
>>>>>>               */
>>>>>>              return 0;
>>>>>>      }
>>>>> Sure I think it is "just" a matter of synchro between the 2 series.
>>>>> Yi,
>>>>
>>>> exactly.
>>>>
>>>>> do you have plans to respin part of
>>>>> [PATCH v7 00/16] vfio: expose virtual Shared Virtual Addressing to VMs
>>>>> or would you allow me to embed this patch in my series.
>>>>
>>>> My v7 hasn’t touch the prq change yet. So I think it's better for
>>>> you to
>>>> embed it to  your series. ^_^>>
>>>
>>> Can you please let me know if you have an updated series of these
>>> patches? It will help me to work with virtio-iommu/arm side changes.
>>
>> As per the previous discussion, I plan to take those 2 patches in my
>> SMMUv3 nested stage series:
>>
>> [PATCH v7 01/16] iommu: Report domain nesting info
>> [PATCH v7 02/16] iommu/smmu: Report empty domain nesting info
>>
>> we need to upgrade both since we do not want to report an empty nesting
>> info anymore, for arm.
>
> Absolutely. Let me send the couple of patches that I have been using,
> that add arm configuration.

Posted the couple of patches that I have been using -

https://lore.kernel.org/linux-iommu/20210212105859.8445-1-vivek.gautam@arm.com/T/#t

Thanks & regards
Vivek

>
> Best regards
> Vivek
>
>>
>> Thanks
>>
>> Eric
>>>
>>> Thanks & regards
>>> Vivek
>>>
>>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu