* [PATCH v2] swiotlb-xen: Convert to use macro
@ 2019-09-02 8:39 Souptick Joarder
2019-09-06 12:27 ` Souptick Joarder
0 siblings, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2019-09-02 8:39 UTC (permalink / raw)
To: konrad.wilk, boris.ostrovsky, jgross, sstabellini
Cc: Souptick Joarder, xen-devel, iommu, linux-kernel, sabyasachi.linux
Rather than using static int max_dma_bits, this
can be coverted to use as macro.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
drivers/xen/swiotlb-xen.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index ae1df49..d1eced5 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -38,6 +38,7 @@
#include <asm/xen/page-coherent.h>
#include <trace/events/swiotlb.h>
+#define MAX_DMA_BITS 32
/*
* Used to do a quick range check in swiotlb_tbl_unmap_single and
* swiotlb_tbl_sync_single_*, to see if the memory was in fact allocated by this
@@ -114,8 +115,6 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
return 0;
}
-static int max_dma_bits = 32;
-
static int
xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs)
{
@@ -135,7 +134,7 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
p + (i << IO_TLB_SHIFT),
get_order(slabs << IO_TLB_SHIFT),
dma_bits, &dma_handle);
- } while (rc && dma_bits++ < max_dma_bits);
+ } while (rc && dma_bits++ < MAX_DMA_BITS);
if (rc)
return rc;
--
1.9.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] swiotlb-xen: Convert to use macro
2019-09-02 8:39 [PATCH v2] swiotlb-xen: Convert to use macro Souptick Joarder
@ 2019-09-06 12:27 ` Souptick Joarder
2019-09-06 13:32 ` Boris Ostrovsky
0 siblings, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2019-09-06 12:27 UTC (permalink / raw)
To: konrad.wilk, Boris Ostrovsky, Juergen Gross, sstabellini
Cc: xen-devel, iommu, linux-kernel, Sabyasachi Gupta
On Mon, Sep 2, 2019 at 2:04 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Rather than using static int max_dma_bits, this
> can be coverted to use as macro.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
If it is still not late, can we get this patch in queue for 5.4 ?
> ---
> drivers/xen/swiotlb-xen.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index ae1df49..d1eced5 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -38,6 +38,7 @@
> #include <asm/xen/page-coherent.h>
>
> #include <trace/events/swiotlb.h>
> +#define MAX_DMA_BITS 32
> /*
> * Used to do a quick range check in swiotlb_tbl_unmap_single and
> * swiotlb_tbl_sync_single_*, to see if the memory was in fact allocated by this
> @@ -114,8 +115,6 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
> return 0;
> }
>
> -static int max_dma_bits = 32;
> -
> static int
> xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs)
> {
> @@ -135,7 +134,7 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
> p + (i << IO_TLB_SHIFT),
> get_order(slabs << IO_TLB_SHIFT),
> dma_bits, &dma_handle);
> - } while (rc && dma_bits++ < max_dma_bits);
> + } while (rc && dma_bits++ < MAX_DMA_BITS);
> if (rc)
> return rc;
>
> --
> 1.9.1
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] swiotlb-xen: Convert to use macro
2019-09-06 12:27 ` Souptick Joarder
@ 2019-09-06 13:32 ` Boris Ostrovsky
2019-09-06 13:35 ` Souptick Joarder
0 siblings, 1 reply; 4+ messages in thread
From: Boris Ostrovsky @ 2019-09-06 13:32 UTC (permalink / raw)
To: Souptick Joarder, konrad.wilk, Juergen Gross, sstabellini
Cc: xen-devel, iommu, linux-kernel, Sabyasachi Gupta
On 9/6/19 8:27 AM, Souptick Joarder wrote:
> On Mon, Sep 2, 2019 at 2:04 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>> Rather than using static int max_dma_bits, this
>> can be coverted to use as macro.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> Reviewed-by: Juergen Gross <jgross@suse.com>
> If it is still not late, can we get this patch in queue for 5.4 ?
Yes, I will queue it later today.
-boris
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] swiotlb-xen: Convert to use macro
2019-09-06 13:32 ` Boris Ostrovsky
@ 2019-09-06 13:35 ` Souptick Joarder
0 siblings, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2019-09-06 13:35 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: Juergen Gross, sstabellini, konrad.wilk, Sabyasachi Gupta,
linux-kernel, iommu, xen-devel
On Fri, Sep 6, 2019 at 7:02 PM Boris Ostrovsky
<boris.ostrovsky@oracle.com> wrote:
>
> On 9/6/19 8:27 AM, Souptick Joarder wrote:
> > On Mon, Sep 2, 2019 at 2:04 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >> Rather than using static int max_dma_bits, this
> >> can be coverted to use as macro.
> >>
> >> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> >> Reviewed-by: Juergen Gross <jgross@suse.com>
> > If it is still not late, can we get this patch in queue for 5.4 ?
>
>
> Yes, I will queue it later today.
Thanks Boris.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-06 13:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-02 8:39 [PATCH v2] swiotlb-xen: Convert to use macro Souptick Joarder
2019-09-06 12:27 ` Souptick Joarder
2019-09-06 13:32 ` Boris Ostrovsky
2019-09-06 13:35 ` Souptick Joarder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).