From: Yong Wu <yong.wu@mediatek.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
cui.zhang@mediatek.com, srv_heupstream@mediatek.com,
edison.hsieh@mediatek.com, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Evan Green <evgreen@chromium.org>,
chao.hao@mediatek.com, Tomasz Figa <tfiga@google.com>,
iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/7] iommu/mediatek: Delete the leaf in the tlb flush
Date: Tue, 15 Oct 2019 13:25:18 +0800 [thread overview]
Message-ID: <1571117118.19130.81.camel@mhfsdcap03> (raw)
In-Reply-To: <20c74c20-864e-88af-3c58-ad3bb7600bcc@arm.com>
On Mon, 2019-10-14 at 15:22 +0100, Robin Murphy wrote:
> On 14/10/2019 07:38, Yong Wu wrote:
> > In our tlb range flush, we don't care the "leaf". Remove it to simplify
> > the code. no functional change.
>
> Presumably you don't care about the granule either?
Yes. I only keep "granule" to satisfy the format of "tlb_flush_walk",
then it's no need add a new helper function.
>
> Robin.
>
> > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> > ---
> > drivers/iommu/mtk_iommu.c | 16 ++++------------
> > 1 file changed, 4 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> > index 8712afc..19f936c 100644
> > --- a/drivers/iommu/mtk_iommu.c
> > +++ b/drivers/iommu/mtk_iommu.c
> > @@ -174,8 +174,7 @@ static void mtk_iommu_tlb_flush_all(void *cookie)
> > }
> >
> > static void mtk_iommu_tlb_add_flush_nosync(unsigned long iova, size_t size,
> > - size_t granule, bool leaf,
> > - void *cookie)
> > + size_t granule, void *cookie)
> > {
> > struct mtk_iommu_data *data = cookie;
> >
> > @@ -219,14 +218,7 @@ static void mtk_iommu_tlb_sync(void *cookie)
> > static void mtk_iommu_tlb_flush_walk(unsigned long iova, size_t size,
> > size_t granule, void *cookie)
> > {
> > - mtk_iommu_tlb_add_flush_nosync(iova, size, granule, false, cookie);
> > - mtk_iommu_tlb_sync(cookie);
> > -}
> > -
> > -static void mtk_iommu_tlb_flush_leaf(unsigned long iova, size_t size,
> > - size_t granule, void *cookie)
> > -{
> > - mtk_iommu_tlb_add_flush_nosync(iova, size, granule, true, cookie);
> > + mtk_iommu_tlb_add_flush_nosync(iova, size, granule, cookie);
> > mtk_iommu_tlb_sync(cookie);
> > }
> >
> > @@ -245,7 +237,7 @@ static void mtk_iommu_tlb_flush_page_nosync(struct iommu_iotlb_gather *gather,
> > static const struct iommu_flush_ops mtk_iommu_flush_ops = {
> > .tlb_flush_all = mtk_iommu_tlb_flush_all,
> > .tlb_flush_walk = mtk_iommu_tlb_flush_walk,
> > - .tlb_flush_leaf = mtk_iommu_tlb_flush_leaf,
> > + .tlb_flush_leaf = mtk_iommu_tlb_flush_walk,
> > .tlb_add_page = mtk_iommu_tlb_flush_page_nosync,
> > };
> >
> > @@ -475,7 +467,7 @@ static void mtk_iommu_iotlb_sync(struct iommu_domain *domain,
> > spin_lock_irqsave(&dom->pgtlock, flags);
> >
> > mtk_iommu_tlb_add_flush_nosync(gather->start, length, gather->pgsize,
> > - false, data);
> > + data);
> > mtk_iommu_tlb_sync(data);
> >
> > if (!is_in_gather)
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-10-15 5:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 6:38 [PATCH v3 0/7] Improve tlb range flush Yong Wu
2019-10-14 6:38 ` [PATCH v3 1/7] iommu/mediatek: Correct the flush_iotlb_all callback Yong Wu
2019-10-14 14:06 ` Robin Murphy
2019-10-14 6:38 ` [PATCH v3 2/7] iommu/mediatek: Add pgtlock in the iotlb_sync Yong Wu
2019-10-14 6:38 ` [PATCH v3 3/7] iommu/mediatek: Use gather to achieve the tlb range flush Yong Wu
2019-10-14 14:21 ` Robin Murphy
2019-10-15 5:26 ` Yong Wu
2019-10-15 11:38 ` Robin Murphy
2019-10-14 6:38 ` [PATCH v3 4/7] iommu/mediatek: Delete the leaf in the tlb flush Yong Wu
2019-10-14 14:22 ` Robin Murphy
2019-10-15 5:25 ` Yong Wu [this message]
2019-10-15 11:24 ` Robin Murphy
2019-10-14 6:38 ` [PATCH v3 5/7] iommu/mediatek: Move the tlb_sync into tlb_flush Yong Wu
2019-10-14 6:38 ` [PATCH v3 6/7] iommu/mediatek: Use writel for TLB range invalidation Yong Wu
2019-10-14 14:04 ` Robin Murphy
2019-10-15 5:25 ` Yong Wu
2019-10-14 6:38 ` [PATCH v3 7/7] iommu/mediatek: Reduce the tlb flush timeout value Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571117118.19130.81.camel@mhfsdcap03 \
--to=yong.wu@mediatek.com \
--cc=anan.sun@mediatek.com \
--cc=chao.hao@mediatek.com \
--cc=cui.zhang@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=edison.hsieh@mediatek.com \
--cc=evgreen@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will.deacon@arm.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).