From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9003C433E0 for ; Wed, 1 Jul 2020 02:18:37 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 880BD2078B for ; Wed, 1 Jul 2020 02:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="PUWLhYJn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 880BD2078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 2EB8E24BB3; Wed, 1 Jul 2020 02:18:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0PziAtir-t7r; Wed, 1 Jul 2020 02:18:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id D733A2201C; Wed, 1 Jul 2020 02:18:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C8E7EC088F; Wed, 1 Jul 2020 02:18:35 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 893E8C016E for ; Wed, 1 Jul 2020 02:18:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 7E00F88DFE for ; Wed, 1 Jul 2020 02:18:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WLnJ4qP+46GA for ; Wed, 1 Jul 2020 02:18:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mailgw02.mediatek.com (unknown [1.203.163.81]) by hemlock.osuosl.org (Postfix) with ESMTP id 549B788DDA for ; Wed, 1 Jul 2020 02:18:32 +0000 (UTC) X-UUID: b0382c5dc1d646658ae7674625c12f39-20200701 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DcY8OQCD9Qm2ySPaa/SLgUyczR+AJ+WptOzp9lGgZhw=; b=PUWLhYJnGHCJl/9g6VyPlszSVCfUbB8XU38bFoDZFp7qrET349sHjz70PVznqSPr9C38gYzmXed+J0aigogGer/4Js5gvtaL1zi2jCtKlniF8Zrsq4gKj4tLBS8DJDUXJuTBrz2CetqHTcgayTqWByUQPoJ9JBXWQPJR88GBJOA=; X-UUID: b0382c5dc1d646658ae7674625c12f39-20200701 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1049815080; Wed, 01 Jul 2020 10:18:19 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32N2.mediatek.inc (172.27.4.72) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 1 Jul 2020 10:18:14 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 1 Jul 2020 10:18:12 +0800 Message-ID: <1593569872.32037.6.camel@mhfsdcap03> Subject: Re: [PATCH v5 02/10] iommu/mediatek: Rename the register STANDARD_AXI_MODE(0x48) to MISC_CTRL From: Yong Wu To: Chao Hao Date: Wed, 1 Jul 2020 10:17:52 +0800 In-Reply-To: <20200629071310.1557-3-chao.hao@mediatek.com> References: <20200629071310.1557-1-chao.hao@mediatek.com> <20200629071310.1557-3-chao.hao@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 71933EE4DC99580A780AB184F067753C98B859006AD047915C8496CEE95F99B82000:8 X-MTK: N Cc: FY Yang , wsd_upstream@mediatek.com, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, 2020-06-29 at 15:13 +0800, Chao Hao wrote: > For iommu offset=0x48 register, only the previous mt8173/mt8183 use the > name STANDARD_AXI_MODE, all the latest SoC extend the register more > feature by different bits, for example: axi_mode, in_order_en, coherent_en > and so on. So rename REG_MMU_MISC_CTRL may be more proper. > > This patch only rename the register name, no functional change. > > Signed-off-by: Chao Hao > Reviewed-by: Yong Wu > Reviewed-by: Matthias Brugger > --- > drivers/iommu/mtk_iommu.c | 14 +++++++------- > drivers/iommu/mtk_iommu.h | 2 +- > 2 files changed, 8 insertions(+), 8 deletions(-) ... > diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h > index ea949a324e33..1b6ea839b92c 100644 > --- a/drivers/iommu/mtk_iommu.h > +++ b/drivers/iommu/mtk_iommu.h > @@ -18,7 +18,7 @@ > #include > > struct mtk_iommu_suspend_reg { > - u32 standard_axi_mode; > + u32 misc_ctrl; Here will cause build fail for v1: drivers/iommu/mtk_iommu_v1.c:675:20: error: 'struct mtk_iommu_suspend_reg' has no member named 'standard_axi_mode' writel_relaxed(reg->standard_axi_mode, ^ We could change something like: union { u32 standard_axi_mode; /* only for v1 */ u32 misc_ctrl; /* only for v2 */ }; > u32 dcm_dis; > u32 ctrl_reg; > u32 int_control0; _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu