From: Will Deacon <will@kernel.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>, robin.murphy@arm.com
Cc: Will Deacon <will@kernel.org>,
catalin.marinas@arm.com, iommu@lists.linux-foundation.org,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iommu/arm-smmu-v3: Fix endianness annotations
Date: Mon, 21 Sep 2020 19:17:38 +0100 [thread overview]
Message-ID: <160071047219.1757999.7743246332571671817.b4-ty@kernel.org> (raw)
In-Reply-To: <20200918141856.629722-1-jean-philippe@linaro.org>
On Fri, 18 Sep 2020 16:18:57 +0200, Jean-Philippe Brucker wrote:
> When building with C=1, sparse reports some issues regarding endianness
> annotations:
>
> arm-smmu-v3.c:221:26: warning: cast to restricted __le64
> arm-smmu-v3.c:221:24: warning: incorrect type in assignment (different base types)
> arm-smmu-v3.c:221:24: expected restricted __le64 [usertype]
> arm-smmu-v3.c:221:24: got unsigned long long [usertype]
> arm-smmu-v3.c:229:20: warning: incorrect type in argument 1 (different base types)
> arm-smmu-v3.c:229:20: expected restricted __le64 [usertype] *[assigned] dst
> arm-smmu-v3.c:229:20: got unsigned long long [usertype] *ent
> arm-smmu-v3.c:229:25: warning: incorrect type in argument 2 (different base types)
> arm-smmu-v3.c:229:25: expected unsigned long long [usertype] *[assigned] src
> arm-smmu-v3.c:229:25: got restricted __le64 [usertype] *
> arm-smmu-v3.c:396:20: warning: incorrect type in argument 1 (different base types)
> arm-smmu-v3.c:396:20: expected restricted __le64 [usertype] *[assigned] dst
> arm-smmu-v3.c:396:20: got unsigned long long *
> arm-smmu-v3.c:396:25: warning: incorrect type in argument 2 (different base types)
> arm-smmu-v3.c:396:25: expected unsigned long long [usertype] *[assigned] src
> arm-smmu-v3.c:396:25: got restricted __le64 [usertype] *
> arm-smmu-v3.c:1349:32: warning: invalid assignment: |=
> arm-smmu-v3.c:1349:32: left side has type restricted __le64
> arm-smmu-v3.c:1349:32: right side has type unsigned long
> arm-smmu-v3.c:1396:53: warning: incorrect type in argument 3 (different base types)
> arm-smmu-v3.c:1396:53: expected restricted __le64 [usertype] *dst
> arm-smmu-v3.c:1396:53: got unsigned long long [usertype] *strtab
> arm-smmu-v3.c:1424:39: warning: incorrect type in argument 1 (different base types)
> arm-smmu-v3.c:1424:39: expected unsigned long long [usertype] *[assigned] strtab
> arm-smmu-v3.c:1424:39: got restricted __le64 [usertype] *l2ptr
>
> [...]
Applied to will (for-joerg/arm-smmu/updates), thanks!
[1/1] iommu/arm-smmu-v3: Fix endianness annotations
https://git.kernel.org/will/c/376cdf66f624
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2020-09-21 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 14:18 [PATCH] iommu/arm-smmu-v3: Fix endianness annotations Jean-Philippe Brucker
2020-09-18 15:02 ` Robin Murphy
2020-09-18 15:08 ` Jean-Philippe Brucker
2020-09-21 18:17 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160071047219.1757999.7743246332571671817.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).