From: Charan Teja Reddy <charante@codeaurora.org>
To: joro@8bytes.org, iommu@lists.linux-foundation.org
Cc: Charan Teja Reddy <charante@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] iommu: of: skip iommu_device_list traversal in of_iommu_xlate()
Date: Wed, 23 Sep 2020 20:23:46 +0530 [thread overview]
Message-ID: <1600872826-2254-1-git-send-email-charante@codeaurora.org> (raw)
In of_iommu_xlate(), check if iommu device is enabled before traversing
the iommu_device_list through iommu_ops_from_fwnode(). It is of no use
in traversing the iommu_device_list only to return NO_IOMMU because of
iommu device node is disabled.
Signed-off-by: Charan Teja Reddy <charante@codeaurora.org>
---
drivers/iommu/of_iommu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index e505b91..225598c 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -94,9 +94,10 @@ static int of_iommu_xlate(struct device *dev,
struct fwnode_handle *fwnode = &iommu_spec->np->fwnode;
int ret;
+ if (!of_device_is_available(iommu_spec->np))
+ return NO_IOMMU;
ops = iommu_ops_from_fwnode(fwnode);
- if ((ops && !ops->of_xlate) ||
- !of_device_is_available(iommu_spec->np))
+ if (ops && !ops->of_xlate)
return NO_IOMMU;
ret = iommu_fwspec_init(dev, &iommu_spec->np->fwnode, ops);
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2020-09-23 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 14:53 Charan Teja Reddy [this message]
2020-09-23 16:24 ` [PATCH] iommu: of: skip iommu_device_list traversal in of_iommu_xlate() Robin Murphy
2020-09-24 4:51 ` Charan Teja Kalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600872826-2254-1-git-send-email-charante@codeaurora.org \
--to=charante@codeaurora.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).