From: Yi Sun <yi.y.sun@linux.intel.com>
To: joro@8bytes.org, dwmw2@infradead.org, baolu.lu@linux.intel.com
Cc: iommu@lists.linux-foundation.org,
Yi Sun <yi.y.sun@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 2/3] iommu: Fix an issue in iommu_page_response() flags check
Date: Wed, 28 Oct 2020 09:36:57 +0800 [thread overview]
Message-ID: <1603849018-6578-3-git-send-email-yi.y.sun@linux.intel.com> (raw)
In-Reply-To: <1603849018-6578-1-git-send-email-yi.y.sun@linux.intel.com>
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
original code fails when LAST_PAGE is set in flags.
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: Liu Yi L <yi.l.liu@intel.com>
Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com>
---
drivers/iommu/iommu.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 8c470f4..053cec3 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1200,9 +1200,11 @@ int iommu_page_response(struct device *dev,
return -EINVAL;
if (msg->version != IOMMU_PAGE_RESP_VERSION_1 ||
- msg->flags & ~IOMMU_PAGE_RESP_PASID_VALID)
+ !(msg->flags & IOMMU_PAGE_RESP_PASID_VALID)) {
+ dev_warn_ratelimited(dev, "%s:Invalid ver %x: flags %x\n",
+ __func__, msg->version, msg->flags);
return -EINVAL;
-
+ }
/* Only send response if there is a fault report pending */
mutex_lock(¶m->fault_param->lock);
if (list_empty(¶m->fault_param->faults)) {
--
2.7.4
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-10-28 1:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 1:36 [PATCH v1 0/3] iommu: Fix a few issues related to PRQ Yi Sun
2020-10-28 1:36 ` [PATCH v1 1/3] iommu/vt-d: Fix prq reporting issues Yi Sun
2020-10-28 4:50 ` Lu Baolu
2020-10-28 6:05 ` Yi Sun
2020-10-28 1:36 ` Yi Sun [this message]
2020-10-28 9:13 ` [PATCH v1 2/3] iommu: Fix an issue in iommu_page_response() flags check Jean-Philippe Brucker
2020-10-29 6:30 ` Yi Sun
2020-10-28 1:36 ` [PATCH v1 3/3] iommu/vt-d: Fix a bug for PDP check in prq_event_thread Yi Sun
2020-10-28 5:05 ` Lu Baolu
2020-10-28 6:06 ` Yi Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603849018-6578-3-git-send-email-yi.y.sun@linux.intel.com \
--to=yi.y.sun@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).