From: Yunfeng Ye <yeyunfeng@huawei.com>
To: Christoph Hellwig <hch@lst.de>, <m.szyprowski@samsung.com>,
<robin.murphy@arm.com>, <iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Cc: Shiyuan Hu <hushiyuan@huawei.com>, Hewenliang <hewenliang4@huawei.com>
Subject: [PATCH] dma-coherent: switch to bitmap_zalloc() in dma_init_coherent_memory()
Date: Sat, 16 May 2020 18:09:38 +0800 [thread overview]
Message-ID: <1b02b07b-617e-bc5c-8619-7a46fba5a512@huawei.com> (raw)
Switch to bitmap_zalloc() to show clearly in dma_init_coherent_memory().
No functional change.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
---
kernel/dma/coherent.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/dma/coherent.c b/kernel/dma/coherent.c
index 2a0c4985f38e..794b31e61ca0 100644
--- a/kernel/dma/coherent.c
+++ b/kernel/dma/coherent.c
@@ -44,7 +44,6 @@ static int dma_init_coherent_memory(phys_addr_t phys_addr,
struct dma_coherent_mem *dma_mem = NULL;
void *mem_base = NULL;
int pages = size >> PAGE_SHIFT;
- int bitmap_size = BITS_TO_LONGS(pages) * sizeof(long);
int ret;
if (!size) {
@@ -62,7 +61,7 @@ static int dma_init_coherent_memory(phys_addr_t phys_addr,
ret = -ENOMEM;
goto out;
}
- dma_mem->bitmap = kzalloc(bitmap_size, GFP_KERNEL);
+ dma_mem->bitmap = bitmap_zalloc(pages, GFP_KERNEL);
if (!dma_mem->bitmap) {
ret = -ENOMEM;
goto out;
@@ -90,7 +89,7 @@ static void dma_release_coherent_memory(struct dma_coherent_mem *mem)
return;
memunmap(mem->virt_base);
- kfree(mem->bitmap);
+ bitmap_free(mem->bitmap);
kfree(mem);
}
--
1.8.3.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2020-05-16 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 10:09 Yunfeng Ye [this message]
2020-07-16 14:47 ` [PATCH] dma-coherent: switch to bitmap_zalloc() in dma_init_coherent_memory() Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b02b07b-617e-bc5c-8619-7a46fba5a512@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=hch@lst.de \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).