From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: don't pass a NULL struct device to DMA API functions Date: Fri, 1 Feb 2019 17:09:57 +0100 Message-ID: <20190201160957.GD6532@lst.de> References: <20190201084801.10983-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: Dmitry Tarnyagin , linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, Felipe Balbi , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Nicolas Ferre , iommu@lists.linux-foundation.org, Sudip Mukherjee , Vinod Koul , netdev@vger.kernel.org, John Crispin , dmaengine@vger.kernel.org, linux-mips@vger.kernel.org, Christoph Hellwig List-Id: iommu@lists.linux-foundation.org On Fri, Feb 01, 2019 at 02:16:08PM +0100, Takashi Iwai wrote: > Actually there are a bunch of ISA sound drivers that still call > allocators with NULL device. > > The patch below should address it, although it's only compile-tested. Oh, I missed these "indirect" calls. This looks good to me: Reviewed-by: Christoph Hellwig