From mboxrd@z Thu Jan 1 00:00:00 1970 From: "joro@8bytes.org" Subject: Re: [PATCH] iommu/ipmmu-vmsa: fix device reference leaks Date: Mon, 11 Feb 2019 11:24:15 +0100 Message-ID: <20190211102414.GZ32526@8bytes.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: wen yang Cc: "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , Laurent Pinchart , Magnus Damm List-Id: iommu@lists.linux-foundation.org Adding a few more people to Cc. On Sun, Feb 03, 2019 at 10:27:09AM +0000, wen yang wrote: > Make sure to drop the reference to the device taken by > of_find_device_by_node() on driver unbind. > > Signed-off-by: Wen Yang > Cc: Joerg Roedel > Cc: iommu@lists.linux-foundation.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/iommu/ipmmu-vmsa.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c > index 7a4529c..cebf56d 100644 > --- a/drivers/iommu/ipmmu-vmsa.c > +++ b/drivers/iommu/ipmmu-vmsa.c > @@ -756,6 +756,9 @@ static int ipmmu_init_platform_device(struct device *dev, > > fwspec->iommu_priv = platform_get_drvdata(ipmmu_pdev); > > + if (!fwspec->iommu_priv) > + put_device(&ipmmu_pdev->dev); > + > return 0; > } > > -- > 2.7.4