From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Srinath Mannam <srinath.mannam@broadcom.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Abhishek Shah <abhishek.shah@broadcom.com>,
Ray Jui <ray.jui@broadcom.com>
Subject: Re: [PATCH v2 2/2] PCI: iproc: Add PCIe 32bit outbound memory configuration
Date: Tue, 12 Feb 2019 18:37:39 +0000 [thread overview]
Message-ID: <20190212183739.GB918@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <1549342622-9929-3-git-send-email-srinath.mannam@broadcom.com>
On Tue, Feb 05, 2019 at 10:27:01AM +0530, Srinath Mannam wrote:
> Add configuration to support IPROC PCIe host controller outbound memory
> window mapping with SOC address range inside 4GB boundary, which is 32 bit
> AXI address.
I do not understand what this means, explain it to me and rewrite the
commit log accordingly.
What does this solve ? Why do we need this patch or rephrased, what
is missing in the current driver ?
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> Signed-off-by: Abhishek Shah <abhishek.shah@broadcom.com>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> Reviewed-by: Vikram Prakash <vikram.prakash@broadcom.com>
Review tags should be given on public mailing lists, these ones seem
to come from non-public review cycles in which case you must drop
them.
> drivers/pci/controller/pcie-iproc.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index b882255..080f142 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -955,8 +955,25 @@ static int iproc_pcie_setup_ob(struct iproc_pcie *pcie, u64 axi_addr,
> resource_size_t window_size =
> ob_map->window_sizes[size_idx] * SZ_1M;
>
> - if (size < window_size)
> - continue;
> + /*
> + * Keep iterating until we reach the last window and
> + * with the minimal window size at index zero. In this
> + * case, we take a compromise by mapping it using the
> + * minimum window size that can be supported
See above, I do not understand clearly what this means.
Lorenzo
> + */
> + if (size < window_size) {
> + if (size_idx > 0 || window_idx > 0)
> + continue;
> +
> + /*
> + * For the corner case of reaching the minimal
> + * window size that can be supported on the
> + * last window
> + */
> + axi_addr = ALIGN_DOWN(axi_addr, window_size);
> + pci_addr = ALIGN_DOWN(pci_addr, window_size);
> + size = window_size;
> + }
>
> if (!IS_ALIGNED(axi_addr, window_size) ||
> !IS_ALIGNED(pci_addr, window_size)) {
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-02-12 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 4:56 [PATCH v2 0/2] Add IPROC PCIe new features Srinath Mannam
2019-02-05 4:57 ` [PATCH v2 1/2] PCI: iproc: Add CRS check in config read Srinath Mannam
2019-02-12 18:12 ` Lorenzo Pieralisi
2019-02-13 3:57 ` Srinath Mannam
2019-02-05 4:57 ` [PATCH v2 2/2] PCI: iproc: Add PCIe 32bit outbound memory configuration Srinath Mannam
2019-02-12 18:37 ` Lorenzo Pieralisi [this message]
2019-02-13 4:51 ` Srinath Mannam
2019-02-05 4:57 ` [PATCH v2 0/2] Add IPROC PCIe new features Srinath Mannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212183739.GB918@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=abhishek.shah@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).