IOMMU Archive on
 help / color / Atom feed
From: Joerg Roedel <>
To: Arnd Bergmann <>
Cc: Oza Pawandeep <>,
	Marc Zyngier <>,,,
	Julien Grall <>,
	Srinath Mannam <>,
	Bjorn Helgaas <>,
	Robin Murphy <>,
	Christoph Hellwig <>
Subject: Re: [PATCH] iommu: fix integer truncation
Date: Tue, 18 Jun 2019 17:25:17 +0200
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Jun 17, 2019 at 03:30:54PM +0200, Arnd Bergmann wrote:
> On 32-bit architectures, phys_addr_t may be different from dma_add_t,
> both smaller and bigger. This can lead to an overflow during an assignment
> that clang warns about:
> drivers/iommu/dma-iommu.c:230:10: error: implicit conversion from 'dma_addr_t' (aka 'unsigned long long') to
>       'phys_addr_t' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
> Use phys_addr_t here because that is the type that the variable was
> declared as.
> Fixes: aadad097cd46 ("iommu/dma: Reserve IOVA for PCIe inaccessible DMA address")
> Signed-off-by: Arnd Bergmann <>

Applied, thanks.
iommu mailing list

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 13:30 Arnd Bergmann
2019-06-18 15:25 ` Joerg Roedel [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IOMMU Archive on

Archives are clonable:
	git clone --mirror linux-iommu/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iommu linux-iommu/ \
	public-inbox-index linux-iommu

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox