* [PATCH] iommu/intel: remove an unused variable "length"
@ 2019-06-17 13:20 Qian Cai
2019-06-17 13:53 ` Auger Eric
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Qian Cai @ 2019-06-17 13:20 UTC (permalink / raw)
To: jroedel; +Cc: linux-kernel, iommu, dwmw2
The linux-next commit "iommu/vt-d: Duplicate iommu_resv_region objects
per device list" [1] left out an unused variable,
drivers/iommu/intel-iommu.c: In function 'dmar_parse_one_rmrr':
drivers/iommu/intel-iommu.c:4014:9: warning: variable 'length' set but
not used [-Wunused-but-set-variable]
[1] https://lore.kernel.org/patchwork/patch/1083073/
Signed-off-by: Qian Cai <cai@lca.pw>
---
drivers/iommu/intel-iommu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 478ac186570b..d86d4ee5cc78 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -4011,7 +4011,6 @@ int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header, void *arg)
{
struct acpi_dmar_reserved_memory *rmrr;
struct dmar_rmrr_unit *rmrru;
- size_t length;
rmrru = kzalloc(sizeof(*rmrru), GFP_KERNEL);
if (!rmrru)
@@ -4022,8 +4021,6 @@ int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header, void *arg)
rmrru->base_address = rmrr->base_address;
rmrru->end_address = rmrr->end_address;
- length = rmrr->end_address - rmrr->base_address + 1;
-
rmrru->devices = dmar_alloc_dev_scope((void *)(rmrr + 1),
((void *)rmrr) + rmrr->header.length,
&rmrru->devices_cnt);
--
2.20.1 (Apple Git-117)
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iommu/intel: remove an unused variable "length"
2019-06-17 13:20 [PATCH] iommu/intel: remove an unused variable "length" Qian Cai
@ 2019-06-17 13:53 ` Auger Eric
2019-06-18 2:25 ` Lu Baolu
2019-06-18 15:30 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Auger Eric @ 2019-06-17 13:53 UTC (permalink / raw)
To: Qian Cai, jroedel; +Cc: iommu, dwmw2, linux-kernel
Hi Qian,
On 6/17/19 3:20 PM, Qian Cai wrote:
> The linux-next commit "iommu/vt-d: Duplicate iommu_resv_region objects
> per device list" [1] left out an unused variable,
>
> drivers/iommu/intel-iommu.c: In function 'dmar_parse_one_rmrr':
> drivers/iommu/intel-iommu.c:4014:9: warning: variable 'length' set but
> not used [-Wunused-but-set-variable]
>
> [1] https://lore.kernel.org/patchwork/patch/1083073/
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thank you for fixing this oversight
Best Regards
Eric
> ---
> drivers/iommu/intel-iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 478ac186570b..d86d4ee5cc78 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -4011,7 +4011,6 @@ int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header, void *arg)
> {
> struct acpi_dmar_reserved_memory *rmrr;
> struct dmar_rmrr_unit *rmrru;
> - size_t length;
>
> rmrru = kzalloc(sizeof(*rmrru), GFP_KERNEL);
> if (!rmrru)
> @@ -4022,8 +4021,6 @@ int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header, void *arg)
> rmrru->base_address = rmrr->base_address;
> rmrru->end_address = rmrr->end_address;
>
> - length = rmrr->end_address - rmrr->base_address + 1;
> -
> rmrru->devices = dmar_alloc_dev_scope((void *)(rmrr + 1),
> ((void *)rmrr) + rmrr->header.length,
> &rmrru->devices_cnt);
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iommu/intel: remove an unused variable "length"
2019-06-17 13:20 [PATCH] iommu/intel: remove an unused variable "length" Qian Cai
2019-06-17 13:53 ` Auger Eric
@ 2019-06-18 2:25 ` Lu Baolu
2019-06-18 15:30 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Lu Baolu @ 2019-06-18 2:25 UTC (permalink / raw)
To: Qian Cai, jroedel; +Cc: iommu, dwmw2, linux-kernel
Hi,
On 6/17/19 9:20 PM, Qian Cai wrote:
> The linux-next commit "iommu/vt-d: Duplicate iommu_resv_region objects
> per device list" [1] left out an unused variable,
>
> drivers/iommu/intel-iommu.c: In function 'dmar_parse_one_rmrr':
> drivers/iommu/intel-iommu.c:4014:9: warning: variable 'length' set but
> not used [-Wunused-but-set-variable]
>
> [1] https://lore.kernel.org/patchwork/patch/1083073/
>
> Signed-off-by: Qian Cai <cai@lca.pw>
With regard to the subject, we normally use "iommu/vt-d: ".
Best regards,
Baolu
> ---
> drivers/iommu/intel-iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 478ac186570b..d86d4ee5cc78 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -4011,7 +4011,6 @@ int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header, void *arg)
> {
> struct acpi_dmar_reserved_memory *rmrr;
> struct dmar_rmrr_unit *rmrru;
> - size_t length;
>
> rmrru = kzalloc(sizeof(*rmrru), GFP_KERNEL);
> if (!rmrru)
> @@ -4022,8 +4021,6 @@ int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header, void *arg)
> rmrru->base_address = rmrr->base_address;
> rmrru->end_address = rmrr->end_address;
>
> - length = rmrr->end_address - rmrr->base_address + 1;
> -
> rmrru->devices = dmar_alloc_dev_scope((void *)(rmrr + 1),
> ((void *)rmrr) + rmrr->header.length,
> &rmrru->devices_cnt);
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iommu/intel: remove an unused variable "length"
2019-06-17 13:20 [PATCH] iommu/intel: remove an unused variable "length" Qian Cai
2019-06-17 13:53 ` Auger Eric
2019-06-18 2:25 ` Lu Baolu
@ 2019-06-18 15:30 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2019-06-18 15:30 UTC (permalink / raw)
To: Qian Cai; +Cc: iommu, dwmw2, linux-kernel
On Mon, Jun 17, 2019 at 09:20:27AM -0400, Qian Cai wrote:
> The linux-next commit "iommu/vt-d: Duplicate iommu_resv_region objects
> per device list" [1] left out an unused variable,
>
> drivers/iommu/intel-iommu.c: In function 'dmar_parse_one_rmrr':
> drivers/iommu/intel-iommu.c:4014:9: warning: variable 'length' set but
> not used [-Wunused-but-set-variable]
>
> [1] https://lore.kernel.org/patchwork/patch/1083073/
>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> drivers/iommu/intel-iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-18 15:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 13:20 [PATCH] iommu/intel: remove an unused variable "length" Qian Cai
2019-06-17 13:53 ` Auger Eric
2019-06-18 2:25 ` Lu Baolu
2019-06-18 15:30 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).