From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172DFC74A5B for ; Thu, 11 Jul 2019 17:28:54 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE67820863 for ; Thu, 11 Jul 2019 17:28:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Adi07l3G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE67820863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 7076D548F; Thu, 11 Jul 2019 17:28:53 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id CCD60530E for ; Thu, 11 Jul 2019 17:19:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 43FE1886 for ; Thu, 11 Jul 2019 17:19:34 +0000 (UTC) Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABEFB20863; Thu, 11 Jul 2019 17:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562865574; bh=gLH594lb7D9WZ94IxT6SdVqv7JFGnY/XiaqTzmOTGbY=; h=From:To:Cc:Subject:Date:From; b=Adi07l3GcOf61Lhvo2UahhfJjKniP+mOeED1h6IKWp3EmEHJAewQGXz4nPVhT8NR1 zwdyGFg3n7AIRlCg6YOsHEgvJorSwvbL+qaukBQUaVJihZn5PemEkYn/ACzabX2YqE q0krFS5vR/m5X0vw3MrMSjy1z0pvajI9d++7Md/w= From: Will Deacon To: iommu@lists.linux-foundation.org Subject: [RFC PATCH v2 00/19] Try to reduce lock contention on the SMMUv3 command queue Date: Thu, 11 Jul 2019 18:19:08 +0100 Message-Id: <20190711171927.28803-1-will@kernel.org> X-Mailer: git-send-email 2.11.0 Cc: Vijay Kilary , Jean-Philippe Brucker , Will Deacon , Jan Glauber , Alex Williamson , Jayachandran Chandrasekharan Nair , Jon Masters , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Hi everyone, This is a significant rework of the RFC I previously posted here: https://lkml.kernel.org/r/20190611134603.4253-1-will.deacon@arm.com But this time, it looks like it might actually be worthwhile according to my perf profiles, where __iommu_unmap() falls a long way down the profile for a multi-threaded netperf run. I'm still relying on others to confirm this is useful, however. Some of the changes since last time are: * Support for constructing and submitting a list of commands in the driver * Numerous changes to the IOMMU and io-pgtable APIs so that we can submit commands in batches * Removal of cmpxchg() from cmdq_shared_lock() fast-path * Code restructuring and cleanups This current applies against my iommu/devel branch that Joerg has pulled for 5.3. If you want to test it out, I've put everything here: https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=iommu/cmdq Feedback welcome. I appreciate that we're in the merge window, but I wanted to get this on the list for people to look at as an RFC. Cheers, Will --->8 Cc: Jean-Philippe Brucker Cc: Robin Murphy Cc: Jayachandran Chandrasekharan Nair Cc: Jan Glauber Cc: Jon Masters Cc: Eric Auger Cc: Zhen Lei Cc: Jonathan Cameron Cc: Vijay Kilary Cc: Joerg Roedel Cc: John Garry Cc: Alex Williamson Will Deacon (19): iommu: Remove empty iommu_tlb_range_add() callback from iommu_ops iommu/io-pgtable-arm: Remove redundant call to io_pgtable_tlb_sync() iommu/io-pgtable: Rename iommu_gather_ops to iommu_flush_ops iommu: Introduce struct iommu_iotlb_gather for batching TLB flushes iommu: Introduce iommu_iotlb_gather_add_page() iommu: Pass struct iommu_iotlb_gather to ->unmap() and ->iotlb_sync() iommu/io-pgtable: Introduce tlb_flush_walk() and tlb_flush_leaf() iommu/io-pgtable: Hook up ->tlb_flush_walk() and ->tlb_flush_leaf() in drivers iommu/io-pgtable-arm: Call ->tlb_flush_walk() and ->tlb_flush_leaf() iommu/io-pgtable: Replace ->tlb_add_flush() with ->tlb_add_page() iommu/io-pgtable: Remove unused ->tlb_sync() callback iommu/io-pgtable: Pass struct iommu_iotlb_gather to ->unmap() iommu/io-pgtable: Pass struct iommu_iotlb_gather to ->tlb_add_page() iommu/arm-smmu-v3: Separate s/w and h/w views of prod and cons indexes iommu/arm-smmu-v3: Drop unused 'q' argument from Q_OVF macro iommu/arm-smmu-v3: Move low-level queue fields out of arm_smmu_queue iommu/arm-smmu-v3: Operate directly on low-level queue where possible iommu/arm-smmu-v3: Reduce contention during command-queue insertion iommu/arm-smmu-v3: Defer TLB invalidation until ->iotlb_sync() drivers/gpu/drm/panfrost/panfrost_mmu.c | 24 +- drivers/iommu/amd_iommu.c | 11 +- drivers/iommu/arm-smmu-v3.c | 856 ++++++++++++++++++++++++-------- drivers/iommu/arm-smmu.c | 103 +++- drivers/iommu/dma-iommu.c | 9 +- drivers/iommu/exynos-iommu.c | 3 +- drivers/iommu/intel-iommu.c | 3 +- drivers/iommu/io-pgtable-arm-v7s.c | 57 +-- drivers/iommu/io-pgtable-arm.c | 48 +- drivers/iommu/iommu.c | 24 +- drivers/iommu/ipmmu-vmsa.c | 28 +- drivers/iommu/msm_iommu.c | 42 +- drivers/iommu/mtk_iommu.c | 45 +- drivers/iommu/mtk_iommu_v1.c | 3 +- drivers/iommu/omap-iommu.c | 2 +- drivers/iommu/qcom_iommu.c | 44 +- drivers/iommu/rockchip-iommu.c | 2 +- drivers/iommu/s390-iommu.c | 3 +- drivers/iommu/tegra-gart.c | 12 +- drivers/iommu/tegra-smmu.c | 2 +- drivers/vfio/vfio_iommu_type1.c | 27 +- include/linux/io-pgtable.h | 57 ++- include/linux/iommu.h | 92 +++- 23 files changed, 1090 insertions(+), 407 deletions(-) -- 2.11.0 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu