From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D35C433FF for ; Tue, 6 Aug 2019 15:46:07 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E54B220717 for ; Tue, 6 Aug 2019 15:46:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E54B220717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id CC745D1A; Tue, 6 Aug 2019 15:46:06 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 7303AD09 for ; Tue, 6 Aug 2019 15:46:06 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0C20289D for ; Tue, 6 Aug 2019 15:46:06 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 96D88227A81; Tue, 6 Aug 2019 17:46:02 +0200 (CEST) Date: Tue, 6 Aug 2019 17:46:02 +0200 From: Christoph Hellwig To: "Lendacky, Thomas" Subject: Re: Regression due to d98849aff879 (dma-direct: handle DMA_ATTR_NO_KERNEL_MAPPING in common code) Message-ID: <20190806154602.GB25050@lst.de> References: <1565082809.2323.24.camel@pengutronix.de> <20190806113318.GA20215@lst.de> <41cc93b1-62b5-7fb6-060d-01982e68503b@amd.com> <20190806140408.GA22902@lst.de> <1565100418.2323.32.camel@pengutronix.de> <78833204-cd30-1a4b-54e3-1580018c6d57@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <78833204-cd30-1a4b-54e3-1580018c6d57@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: "linux-kernel@vger.kernel.org" , Halil Pasic , "iommu@lists.linux-foundation.org" , Christoph Hellwig , Lucas Stach X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Tue, Aug 06, 2019 at 02:18:49PM +0000, Lendacky, Thomas wrote: > I think you need to keep everything inside the original if statement since > the caller is expecting a page pointer to be returned in this case and not > the page_address() which is returned when the DMA_ATTR_NO_KERNEL_MAPPING > is not present. DMA_ATTR_NO_KERNEL_MAPPING is defined to return an opaque cookie, which just happens to be a page pointer. So if we fix up the free side as pointed out by Lucas we should be fine. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu