From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC1E2C433FF for ; Thu, 15 Aug 2019 10:55:58 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 813C621783 for ; Thu, 15 Aug 2019 10:55:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OdK2muyF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 813C621783 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 5CDC5D9C; Thu, 15 Aug 2019 10:55:58 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 2F8D8D1A for ; Thu, 15 Aug 2019 10:55:57 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id DDF9067F for ; Thu, 15 Aug 2019 10:55:56 +0000 (UTC) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 266BA21744; Thu, 15 Aug 2019 10:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565866556; bh=7cf4u3cY/l0YA9m9qv/SdhxS5YxC0bDqvVYfflUHsl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OdK2muyFm8nJoIib88QYXlUtuWPQjraO7qRKkgYePLXqu7zRAu8CWQP8blWFK+Vkk 5Jd+6oSmObvX5FAiL8BV2Ls2FBN4h1pitzYI91Xw+CAkNkvJ5yh/JbARLLgtwxBjyS RtFyOm/+pNSIMLnK6LNa+etZmvUQ2z3p+/NdoqvY= Date: Thu, 15 Aug 2019 11:55:52 +0100 From: Will Deacon To: Robin Murphy Subject: Re: [PATCH 00/15] Arm SMMU refactoring Message-ID: <20190815105551.zqn45le3kd3f3jee@willie-the-truck> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Cc: bjorn.andersson@linaro.org, iommu@lists.linux-foundation.org, gregory.clement@bootlin.com, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Hi Robin, On Fri, Aug 09, 2019 at 06:07:37PM +0100, Robin Murphy wrote: > This is a big refactoring of arm-smmu in order to help cope with the > various divergent implementation details currently flying around. So > far we've been accruing various quirks and errata workarounds within > the main flow of the driver, but given that it's written to an > architecture rather than any particular hardware implementation, after > a point these start to become increasingly invasive and potentially > conflict with each other. > > These patches clean up the existing quirks handled by the driver to > lay a foundation on which we can continue to add more in a maintainable > fashion. The idea is that major vendor customisations can then be kept > in arm-smmu-.c implementation files out of each others' way. > > A branch is available at: > > git://linux-arm.org/linux-rm iommu/smmu-impl > > which I'll probably keep tweaking until I'm happy with the names of > things; I just didn't want to delay this initial posting any lomnger. Thanks, this all looks pretty decent to me. I've mainly left you a bunch of nits (hey, it's a refactoring series!) but I did spot one pre-existing howler that we should address. When do you think you'll have stopped tweaking this so that I can pick it up? I'd really like to see it in 5.4 so that others can start working on top of it. Cheers, Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu