From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46162C3A5A2 for ; Tue, 20 Aug 2019 02:14:59 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1058022CEC for ; Tue, 20 Aug 2019 02:14:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1058022CEC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D0CEBC8F; Tue, 20 Aug 2019 02:14:58 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 8FC72C8B for ; Tue, 20 Aug 2019 02:14:57 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 31D9B8A6 for ; Tue, 20 Aug 2019 02:14:57 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B85B468B02; Tue, 20 Aug 2019 04:14:52 +0200 (CEST) Date: Tue, 20 Aug 2019 04:14:52 +0200 From: Christoph Hellwig To: Nicolin Chen Subject: Re: regression in ath10k dma allocation Message-ID: <20190820021452.GA22792@lst.de> References: <8fe8b415-2d34-0a14-170b-dcb31c162e67@mni.thm.de> <20190816164301.GA3629@lst.de> <20190816222506.GA24413@Asurada-Nvidia.nvidia.com> <20190818031328.11848-1-hdanton@sina.com> <20190820015852.GA15830@Asurada-Nvidia.nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190820015852.GA15830@Asurada-Nvidia.nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Hillf Danton , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, davem@davemloft.net, iommu@lists.linux-foundation.org, tobias.klausmann@freenet.de, Tobias Klausmann , robin.murphy@arm.com, Christoph Hellwig , kvalo@codeaurora.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Mon, Aug 19, 2019 at 06:58:52PM -0700, Nicolin Chen wrote: > Right...the condition was in-between. However, not every caller > of dma_alloc_contiguous() is supposed to have a coherent check. > So we either add a 'bool coherent_ok' to the API or revert the > dma-direct part back to the original. Probably former option is > better? > > Thank you for the debugging. I have been a bit distracted, may > not be able to submit a fix very soon. Would you like to help? Yeah, it turns out that while the idea for the dma_alloc_contiguous helper was neat it didn't work out at all, and me pushing Nicolin down that route was not a very smart idea. Sorry for causing this mess. I think we'll just need to open code it for dma-direct for 5.3. Hillf do you want to cook up a patch or should I do it? _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu