From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184D4C3A589 for ; Tue, 20 Aug 2019 07:04:57 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D255622CF5 for ; Tue, 20 Aug 2019 07:04:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2nWBnyvN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D255622CF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id AC1D0D56; Tue, 20 Aug 2019 07:04:56 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id AD18ED13 for ; Tue, 20 Aug 2019 07:04:55 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 68A2B87 for ; Tue, 20 Aug 2019 07:04:55 +0000 (UTC) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B2FD20C01; Tue, 20 Aug 2019 07:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566284695; bh=k8rmf+NYWBrNwDZWHXITwAsQXxQMUUCm38mRV4YkvEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2nWBnyvNSVa2/Mvwppf+LtBamrCz0V1mPUT5/SIuUh4vd1nOpRDP4XQldLJppe3ba CXuDyMRRUqmaWu5nB8Vh+J62GEqhpvPOF+tDHhnpQWT7ILkp4wqxEaVvL/qAjgKedX Yo96ZwQfXZBQgfuWWeqDih+xbFmaPEGIEprzWMcg= Date: Tue, 20 Aug 2019 08:04:50 +0100 From: Will Deacon To: Robin Murphy Subject: Re: [PATCH v2 00/17] Arm SMMU refactoring Message-ID: <20190820070449.mjqmmn4me364lta5@willie-the-truck> References: <20190819155634.xflkhxexzks3y7oa@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Cc: bjorn.andersson@linaro.org, iommu@lists.linux-foundation.org, gregory.clement@bootlin.com, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Mon, Aug 19, 2019 at 07:10:45PM +0100, Robin Murphy wrote: > On 19/08/2019 16:56, Will Deacon wrote: > > On Thu, Aug 15, 2019 at 07:37:20PM +0100, Robin Murphy wrote: > > > v1 for context: https://patchwork.kernel.org/cover/11087347/ > > > > > > Here's a quick v2 attempting to address all the minor comments; I've > > > tweaked a whole bunch of names, added some verbosity in macros and > > > comments for clarity, and rejigged arm_smmu_impl_init() for a bit more > > > structure. The (new) patches #1 and #2 are up front as conceptual fixes, > > > although they're not actually critical - it turns out to be more of an > > > embarrassment than a real problem in practice. > > > > Thanks, I'll pick this up and send to Joerg later this week. > > Oops, I've just noticed that the io-64-nonatomic-hi-lo.h include also needs > to move to arm-smmu.h in #14 to avoid breaking 32-bit builds. I've pushed > out an updated branch (along with the static fixes for good measure) - let > me know if you'd like a resend of the patches. Can you just send a patch on top instead, please? I'd prefer not to rebase things unless we really need to, and I've already pushed this stuff to for-joerg/arm-smmu/refactoring. Thanks, Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu