From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B40FDC3A59F for ; Thu, 29 Aug 2019 12:41:22 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A7F02339E for ; Thu, 29 Aug 2019 12:41:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BEHX6O5k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A7F02339E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 2678646E4; Thu, 29 Aug 2019 12:41:22 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B34B446CC for ; Thu, 29 Aug 2019 12:40:39 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 6B01E3D0 for ; Thu, 29 Aug 2019 12:40:38 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id h13so3878645edq.10 for ; Thu, 29 Aug 2019 05:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wmJIhmpe5eh+/gW/vr2H2oqa0HY38tUTFnJyQ/g2lnw=; b=BEHX6O5kpPqJazg+Y2J0VIoeG6AGVw4bHdRUQz3Gp24W7bpATqmb1cfj0SUVh8svAj jiNgAROYNIATDIu9Mh2tlTxusICw/9IFN/1wKDB5WUfdvb+Vsab94ha496M/YAk/tAiR YENrFGmeZ/jNzTJOv9nr4gztoyemotgelzf9AugZtZ36/RY6JSlCcJJyXO680UrNfmjf PgZ+lTtcUUsC291zWbuA4EjqHWemFIe2zMX+Ata+yPcafZfq96PszMER/vtQ6ZiNuYrX 1DfAvqVgff1f7PcBVSCLE6C+l/bYgJ66YeekAN69XoYJgO+WzUSmqzMDKSf96bGPAgHe 1NLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wmJIhmpe5eh+/gW/vr2H2oqa0HY38tUTFnJyQ/g2lnw=; b=mvCo2UhqYs83qCWTTJspItF7TRdBXv3JRT+E8pyeiwOdIXkMYdnE7Z0cYQXQKEhnDL UEa/05VJWGJa8sxEXfyFR1FxBzPGHcR6/HEvyT8wBYlkSy1/3sSYZeAwSQwyNWSfZ7fd 90DEdotCtYypul2T+TdkajPgzpf94pyRBKuYoKtJ+7BofWep6RrJmX0gQ0VVwLj3jw5G yEbRzrTaj0arDOhnivLFDI0jpdrbThgv1QLQ/QHrdMLHbFMthkbmbHB/bTJ7JwyAMd9j +kHRUD+gKMe6e0j96cGYGtclfn+qJZVAik+ZIrlc1SSAAG1OKu0qog8Hpvz15I5ZLeJs KLfA== X-Gm-Message-State: APjAAAUrJZ7eBpm3jYBy4EDDgaaiMqACNcgCTjPAGnM8K1cSaWR2/5r2 NgTddib5SM+ccq27QQU9u/A= X-Google-Smtp-Source: APXvYqwH9FMfs2BkjfucZGdoByxkMhDUjVy7mZQxKMVesrJgd1wU7+pYohArwwuIOgvcTiwdJw/6Vw== X-Received: by 2002:a17:906:c2c9:: with SMTP id ch9mr8121634ejb.167.1567082436874; Thu, 29 Aug 2019 05:40:36 -0700 (PDT) Received: from localhost (pD9E51890.dip0.t-ipconnect.de. [217.229.24.144]) by smtp.gmail.com with ESMTPSA id l26sm367862ejg.70.2019.08.29.05.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 05:40:35 -0700 (PDT) Date: Thu, 29 Aug 2019 14:40:34 +0200 From: Thierry Reding To: Hans Verkuil Subject: Re: [PATCH] media: staging: tegra-vde: Disable building with COMPILE_TEST Message-ID: <20190829124034.GA19842@ulmo> References: <20190826133140.13456-1-yuehaibing@huawei.com> <7f73bcac-f52d-f1b3-324c-e9b551c5378b@xs4all.nl> MIME-Version: 1.0 In-Reply-To: <7f73bcac-f52d-f1b3-324c-e9b551c5378b@xs4all.nl> User-Agent: Mutt/1.12.1 (2019-06-15) Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, YueHaibing , linux-kernel@vger.kernel.org, jonathanh@nvidia.com, iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, digetx@gmail.com, mchehab@kernel.org, robin.murphy@arm.com, linux-media@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0184708654491115222==" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org --===============0184708654491115222== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 29, 2019 at 01:39:32PM +0200, Hans Verkuil wrote: > On 8/26/19 3:31 PM, YueHaibing wrote: > > If COMPILE_TEST is y and IOMMU_SUPPORT is n, selecting TEGRA_VDE > > to m will set IOMMU_IOVA to m, this fails the building of > > TEGRA_HOST1X and DRM_TEGRA which is y like this: > >=20 > > drivers/gpu/host1x/cdma.o: In function `host1x_cdma_init': > > cdma.c:(.text+0x66c): undefined reference to `alloc_iova' > > cdma.c:(.text+0x698): undefined reference to `__free_iova' > >=20 > > drivers/gpu/drm/tegra/drm.o: In function `tegra_drm_unload': > > drm.c:(.text+0xeb0): undefined reference to `put_iova_domain' > > drm.c:(.text+0xeb4): undefined reference to `iova_cache_put' > >=20 > > Reported-by: Hulk Robot > > Fixes: 6b2265975239 ("media: staging: tegra-vde: Fix build error") > > Fixes: b301f8de1925 ("media: staging: media: tegra-vde: Add IOMMU suppo= rt") > > Signed-off-by: YueHaibing > > --- > > drivers/staging/media/tegra-vde/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/drivers/staging/media/tegra-vde/Kconfig b/drivers/staging/= media/tegra-vde/Kconfig > > index ba49ea5..a41d30c 100644 > > --- a/drivers/staging/media/tegra-vde/Kconfig > > +++ b/drivers/staging/media/tegra-vde/Kconfig > > @@ -1,9 +1,9 @@ > > # SPDX-License-Identifier: GPL-2.0 > > config TEGRA_VDE > > tristate "NVIDIA Tegra Video Decoder Engine driver" > > - depends on ARCH_TEGRA || COMPILE_TEST > > + depends on ARCH_TEGRA >=20 > What happens if you drop this change, >=20 > > select DMA_SHARED_BUFFER > > - select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) > > + select IOMMU_IOVA if IOMMU_SUPPORT >=20 > but keep this change? >=20 > iova.h has stubs that are used if IOMMU_IOVA is not set, so it should > work when compile testing this tegra-vde driver. >=20 > Haven't tried it, but making sure that compile testing keep working is > really important. Yeah, that variant seems to work for me. I think it's also more correct because the IOMMU_IOVA if IOMMU_SUPPORT dependency really says that the IOVA usage is bound to IOMMU support. If IOMMU support is not enabled, then IOVA is not needed either, so the dummies will do just fine. Thierry --2fHTh5uZTiUOsy+g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl1nx78ACgkQ3SOs138+ s6FjdBAAjPVTLKQa12c+8O/ecTX4Bkd37JWHnmOyfuQByXvgyFwDufWK1I19NpQh gunYeGFxSe36t4aIK8w27Jtr86Zo7tw8xUmNs2cZrNLZahvEx4DERmV3VeqqKv8L hNjLT61akI4MlN7rGpRcwbUrtL39NJW3msO/NzvnZAy8EetobwDPVkcyhG+XfQhc XsNXJhnvj3W5PR1+RzhL1i2UGwpc4HhLEFjHgzHcBsVgo6QixR/vSCNQ+mJPEcsz G5NRpG8zqh6gGUCs4Fxi2Pn6FwWqYaqyqBbSZoAydYULWMhEUsZPTiyihsOP2PxM V8ni2vhx6hzqlr0Sml5LfsT8eDjuKLFHacfFzg0ediSy7HI3p8hxotcdZXfJ0T9G q1W7wK5WDhA3FP/z9iBQRjryaTUUQtf/F1NBMvTPvIfUipxqcgYq2/SayQ12g/9l e36ocSD+yuI0sZNa549AVTF5hYmmbkGAcrX+vF6OB0e0tGZoPAmBvQwd7XH2MHzI T2r6b1S4WMlZ6XX4ko8boqXVGzO8cGybF2S3pdNnQrWQc/EiFimCLlxVFjdvR6w2 MdzxVAYlU47MNIhMaCbOCzEW5lq6krlMSVC3vpK13RGegyM7LHp5XXrhnRk5n6yf Ap68NCbc9fsg3oNPcddpiHnadEVLap36FWSpLixSYuZLUevnhZc= =jI77 -----END PGP SIGNATURE----- --2fHTh5uZTiUOsy+g-- --===============0184708654491115222== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu --===============0184708654491115222==--