IOMMU Archive on lore.kernel.org
 help / color / Atom feed
* "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64
@ 2019-09-03  2:10 Qian Cai
  2019-09-03  6:40 ` Will Deacon
  0 siblings, 1 reply; 2+ messages in thread
From: Qian Cai @ 2019-09-03  2:10 UTC (permalink / raw)
  To: Will Deacon
  Cc: iommu, Joerg Roedel, Robin Murphy, linux-kernel, linux-arm-kernel

The linux-next commit “iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters” [1] causes a compilation error when PCI_ATS=n on arm64.

[1] https://lore.kernel.org/linux-iommu/20190820154549.17018-3-will@kernel.org/

drivers/iommu/arm-smmu-v3.c:2325:35: error: no member named 'ats_cap' in 'struct pci_dev'
        return !pdev->untrusted && pdev->ats_cap;
                                   ~~~~  ^

For example,

Symbol: PCI_ATS [=n]
  │ Type  : bool
  │   Defined at drivers/pci/Kconfig:118
  │   Depends on: PCI [=y] 
  │   Selected by [n]: 
  │   - PCI_IOV [=n] && PCI [=y] 
  │   - PCI_PRI [=n] && PCI [=y]│  
  │   - PCI_PASID [=n] && PCI [=y] │  
  │   - AMD_IOMMU [=n] && IOMMU_SUPPORT [=y] && X86_64 && PCI [=y] && ACPI [=y]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64
  2019-09-03  2:10 "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64 Qian Cai
@ 2019-09-03  6:40 ` Will Deacon
  0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2019-09-03  6:40 UTC (permalink / raw)
  To: Qian Cai
  Cc: iommu, Joerg Roedel, Robin Murphy, linux-kernel, linux-arm-kernel

On Mon, Sep 02, 2019 at 10:10:30PM -0400, Qian Cai wrote:
> The linux-next commit “iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters” [1] causes a compilation error when PCI_ATS=n on arm64.
> 
> [1] https://lore.kernel.org/linux-iommu/20190820154549.17018-3-will@kernel.org/
> 
> drivers/iommu/arm-smmu-v3.c:2325:35: error: no member named 'ats_cap' in 'struct pci_dev'
>         return !pdev->untrusted && pdev->ats_cap;
>                                    ~~~~  ^
> 
> For example,
> 
> Symbol: PCI_ATS [=n]
>   │ Type  : bool
>   │   Defined at drivers/pci/Kconfig:118
>   │   Depends on: PCI [=y] 
>   │   Selected by [n]: 
>   │   - PCI_IOV [=n] && PCI [=y] 
>   │   - PCI_PRI [=n] && PCI [=y]│  
>   │   - PCI_PASID [=n] && PCI [=y] │  
>   │   - AMD_IOMMU [=n] && IOMMU_SUPPORT [=y] && X86_64 && PCI [=y] && ACPI [=y]

https://lkml.kernel.org/r/20190903063028.6ryuk5dmaohi2fqa@willie-the-truck

Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03  2:10 "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64 Qian Cai
2019-09-03  6:40 ` Will Deacon

IOMMU Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iommu/0 linux-iommu/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iommu linux-iommu/ https://lore.kernel.org/linux-iommu \
		iommu@lists.linux-foundation.org iommu@archiver.kernel.org
	public-inbox-index linux-iommu


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linux-foundation.lists.iommu


AGPL code for this site: git clone https://public-inbox.org/ public-inbox