From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
iommu@lists.linux-foundation.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Loic Pallardy <loic.pallardy@st.com>
Subject: Re: [PATCH 3/4] remoteproc: don't allow modular build
Date: Tue, 3 Sep 2019 14:07:39 -0700 [thread overview]
Message-ID: <20190903210739.GW6167@minitux> (raw)
In-Reply-To: <20190902200746.16185-4-hch@lst.de>
On Mon 02 Sep 13:07 PDT 2019, Christoph Hellwig wrote:
> Remoteproc started using dma_declare_coherent_memory recently, which is
> a bad idea from drivers, and the maintainers agreed to fix that. But
> until that is fixed only allow building the driver built in so that we
> can remove the dma_declare_coherent_memory export and prevent other
> drivers from "accidentally" using it like remoteproc. Note that the
> driver would also leak the declared coherent memory on unload if it
> actually was built as a module at the moment.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Please pick this together with the other patches.
Regards,
Bjorn
> ---
> drivers/remoteproc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 28ed306982f7..94afdde4bc9f 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -2,7 +2,7 @@
> menu "Remoteproc drivers"
>
> config REMOTEPROC
> - tristate "Support for Remote Processor subsystem"
> + bool "Support for Remote Processor subsystem"
> depends on HAS_DMA
> select CRC32
> select FW_LOADER
> --
> 2.20.1
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-09-03 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 20:07 remove various dma_declare_coherent related exports Christoph Hellwig
2019-09-02 20:07 ` [PATCH 1/4] dma-mapping: remove dma_release_declared_memory Christoph Hellwig
2019-09-02 20:07 ` [PATCH 2/4] dma-mapping: remove the dma_mmap_from_dev_coherent export Christoph Hellwig
2019-09-02 20:07 ` [PATCH 3/4] remoteproc: don't allow modular build Christoph Hellwig
2019-09-03 21:07 ` Bjorn Andersson [this message]
2019-09-04 9:05 ` Christoph Hellwig
2019-09-02 20:07 ` [PATCH 4/4] dma-mapping: remove the dma_declare_coherent_memory export Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903210739.GW6167@minitux \
--to=bjorn.andersson@linaro.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).