From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF8EC49ED9 for ; Thu, 12 Sep 2019 07:44:10 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D69F1208C2 for ; Thu, 12 Sep 2019 07:44:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D69F1208C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id B66EEC9A; Thu, 12 Sep 2019 07:44:09 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id AE202ACD for ; Thu, 12 Sep 2019 07:44:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [85.220.165.71]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 16C2E81A for ; Thu, 12 Sep 2019 07:44:08 +0000 (UTC) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i8Jlr-0001qk-0T; Thu, 12 Sep 2019 09:44:03 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1i8Jlh-00023h-Ee; Thu, 12 Sep 2019 09:43:53 +0200 Date: Thu, 12 Sep 2019 09:43:53 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Joerg Roedel Subject: Re: [PATCH v1 1/2] iommu: pass cell_count = -1 to of_for_each_phandle with cells_name Message-ID: <20190912074353.wqohpfydjxueqade@pengutronix.de> References: <20190824132846.8589-1-u.kleine-koenig@pengutronix.de> <20190903125210.GB11530@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190903125210.GB11530@8bytes.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: iommu@lists.linux-foundation.org Cc: devicetree@vger.kernel.org, Will Deacon , Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger , Frank Rowand , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Tue, Sep 03, 2019 at 02:52:10PM +0200, Joerg Roedel wrote: > On Sat, Aug 24, 2019 at 03:28:45PM +0200, Uwe Kleine-K=F6nig wrote: > > Currently of_for_each_phandle ignores the cell_count parameter when a > > cells_name is given. I intend to change that and let the iterator fall > > back to a non-negative cell_count if the cells_name property is missing > > in the referenced node. > > = > > To not change how existing of_for_each_phandle's users iterate, fix them > > to pass cell_count =3D -1 when also cells_name is given which yields the > > expected behaviour with and without my change. > > = > > Signed-off-by: Uwe Kleine-K=F6nig > > --- > > drivers/iommu/arm-smmu.c | 2 +- > > drivers/iommu/mtk_iommu_v1.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > = > Acked-by: Joerg Roedel Does this ack mean that Rob is expected to apply this together with patch 2? Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu