From: Christoph Hellwig <hch@lst.de>
To: "Lendacky, Thomas" <Thomas.Lendacky@amd.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"Singh, Brijesh" <brijesh.singh@amd.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ming Lei <ming.lei@redhat.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Peter Gonda <pgonda@google.com>,
David Rientjes <rientjes@google.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Jianxiong Gao <jxgao@google.com>
Subject: Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage
Date: Wed, 18 Sep 2019 15:22:42 +0200 [thread overview]
Message-ID: <20190918132242.GA16133@lst.de> (raw)
In-Reply-To: <1d74607e-37f7-56ca-aba3-5a3bd7a68561@amd.com>
On Tue, Sep 17, 2019 at 06:41:02PM +0000, Lendacky, Thomas wrote:
> > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> > --- a/drivers/nvme/host/pci.c
> > +++ b/drivers/nvme/host/pci.c
> > @@ -1613,7 +1613,8 @@ static int nvme_alloc_admin_tags(struct nvme_dev *dev)
> > dev->admin_tagset.timeout = ADMIN_TIMEOUT;
> > dev->admin_tagset.numa_node = dev_to_node(dev->dev);
> > dev->admin_tagset.cmd_size = sizeof(struct nvme_iod);
> > - dev->admin_tagset.flags = BLK_MQ_F_NO_SCHED;
> > + dev->admin_tagset.flags = BLK_MQ_F_NO_SCHED |
> > + BLK_MQ_F_BLOCKING;
>
> I think you want to only set the BLK_MQ_F_BLOCKING if the DMA is required
> to be unencrypted. Unfortunately, force_dma_unencrypted() can't be called
> from a module. Is there a DMA API that could be called to get that info?
The DMA API must support non-blocking calls, and various drivers rely
on that. So we need to provide that even for the SEV case. If the
actual blocking can't be made to work we'll need to wire up the DMA
pool in kernel/dma/remap.c for it (and probably move it to separate
file).
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-09-18 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.21.1909041434580.160038@chino.kir.corp.google.com>
2019-09-05 6:06 ` [bug] __blk_mq_run_hw_queue suspicious rcu usage Christoph Hellwig
2019-09-05 22:37 ` David Rientjes via iommu
2019-09-16 23:45 ` David Rientjes via iommu
2019-09-17 18:23 ` David Rientjes via iommu
2019-09-17 18:32 ` Jens Axboe
2019-09-17 18:41 ` Lendacky, Thomas
2019-09-18 13:22 ` Christoph Hellwig [this message]
2019-11-27 22:11 ` David Rientjes via iommu
2019-11-28 6:40 ` Christoph Hellwig
2019-12-13 0:07 ` David Rientjes via iommu
2019-12-13 9:33 ` David Rientjes via iommu
2019-12-15 5:38 ` David Rientjes via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918132242.GA16133@lst.de \
--to=hch@lst.de \
--cc=Thomas.Lendacky@amd.com \
--cc=axboe@kernel.dk \
--cc=brijesh.singh@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jxgao@google.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).