Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on pm/linux-next] [cannot apply to v5.3 next-20190920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-utils-Describe-function-parameters-in-kernel-doc/20190924-230504 base: https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from include/linux/acpi.h:32:0, from drivers/acpi/acpi_lpss.c:10: include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~ drivers/acpi/acpi_lpss.c: In function 'acpi_lpss_is_supplier': >> drivers/acpi/acpi_lpss.c:484:32: error: passing argument 1 of 'acpi_dev_hid_uid_match' from incompatible pointer type [-Werror=incompatible-pointer-types] return acpi_dev_hid_uid_match(adev, link->supplier_hid, link->supplier_uid); ^~~~ In file included from include/linux/acpi.h:32:0, from drivers/acpi/acpi_lpss.c:10: include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but argument is of type 'struct acpi_device *' bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~~~~~~~~~~~~ drivers/acpi/acpi_lpss.c: In function 'acpi_lpss_is_consumer': drivers/acpi/acpi_lpss.c:490:32: error: passing argument 1 of 'acpi_dev_hid_uid_match' from incompatible pointer type [-Werror=incompatible-pointer-types] return acpi_dev_hid_uid_match(adev, link->consumer_hid, link->consumer_uid); ^~~~ In file included from include/linux/acpi.h:32:0, from drivers/acpi/acpi_lpss.c:10: include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but argument is of type 'struct acpi_device *' bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~~~~~~~~~~~~ drivers/acpi/acpi_lpss.c: In function 'match_hid_uid': drivers/acpi/acpi_lpss.c:506:32: error: passing argument 1 of 'acpi_dev_hid_uid_match' from incompatible pointer type [-Werror=incompatible-pointer-types] return acpi_dev_hid_uid_match(adev, id->hid, id->uid); ^~~~ In file included from include/linux/acpi.h:32:0, from drivers/acpi/acpi_lpss.c:10: include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but argument is of type 'struct acpi_device *' bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/acpi_dev_hid_uid_match +484 drivers/acpi/acpi_lpss.c 480 481 static bool acpi_lpss_is_supplier(struct acpi_device *adev, 482 const struct lpss_device_links *link) 483 { > 484 return acpi_dev_hid_uid_match(adev, link->supplier_hid, link->supplier_uid); 485 } 486 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation