IOMMU Archive on lore.kernel.org
 help / color / Atom feed
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Filippo Sironi <sironi@amazon.de>,
	iommu@lists.linux-foundation.org, jroedel@suse.de
Subject: Re: [PATCH 0/6] iommu/amd: Locking Fixes
Date: Wed, 25 Sep 2019 17:25:15 -0700
Message-ID: <20190926002515.3xjm3fb6z42dfhar@cantor> (raw)
In-Reply-To: <20190925132300.3038-1-joro@8bytes.org>

On Wed Sep 25 19, Joerg Roedel wrote:
>Hi,
>
>here are a couple of fixes for the amd iommu driver to fix a
>few locking issues around protection-domains. Main problem
>was that some traversals of ->dev_list were not locked in
>any form, causing potential race conditions.
>
>But there are more issues fixed here, for example the racy
>access to protection_domain->updated and races in the
>attach/detach_device code paths.
>
>Changes are boot-tested with lockdep enabled, looked all
>good so far.
>
>Please review.
>
>Thanks,
>
>	Joerg
>
>Joerg Roedel (6):
>  iommu/amd: Remove domain->updated
>  iommu/amd: Remove amd_iommu_devtable_lock
>  iommu/amd: Take domain->lock for complete attach/detach path
>  iommu/amd: Check for busy devices earlier in attach_device()
>  iommu/amd: Lock dev_data in attach/detach code paths
>  iommu/amd: Lock code paths traversing protection_domain->dev_list
>
> drivers/iommu/amd_iommu.c       | 166 ++++++++++++++++----------------
> drivers/iommu/amd_iommu_types.h |   4 +-
> 2 files changed, 85 insertions(+), 85 deletions(-)
>
>-- 
>2.17.1
>
>_______________________________________________
>iommu mailing list
>iommu@lists.linux-foundation.org
>https://lists.linuxfoundation.org/mailman/listinfo/iommu

Hi Joerg,

What branch is this on top of in your repo?

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  parent reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 13:22 Joerg Roedel
2019-09-25 13:22 ` [PATCH 1/6] iommu/amd: Remove domain->updated Joerg Roedel
2019-09-25 15:45   ` Sironi, Filippo via iommu
2019-09-26  6:18   ` Jerry Snitselaar
2019-09-25 13:22 ` [PATCH 2/6] iommu/amd: Remove amd_iommu_devtable_lock Joerg Roedel
2019-09-25 15:50   ` Sironi, Filippo via iommu
2019-09-25 15:52     ` Sironi, Filippo via iommu
2019-09-26  6:24   ` Jerry Snitselaar
2019-09-25 13:22 ` [PATCH 3/6] iommu/amd: Take domain->lock for complete attach/detach path Joerg Roedel
2019-09-25 15:53   ` Sironi, Filippo via iommu
2019-09-26  6:34   ` Jerry Snitselaar
2019-09-25 13:22 ` [PATCH 4/6] iommu/amd: Check for busy devices earlier in attach_device() Joerg Roedel
2019-09-25 15:55   ` Sironi, Filippo via iommu
2019-09-26  6:37   ` Jerry Snitselaar
2019-09-25 13:22 ` [PATCH 5/6] iommu/amd: Lock dev_data in attach/detach code paths Joerg Roedel
2019-09-25 15:56   ` Sironi, Filippo via iommu
2019-09-26  6:41   ` Jerry Snitselaar
2019-09-25 13:23 ` [PATCH 6/6] iommu/amd: Lock code paths traversing protection_domain->dev_list Joerg Roedel
2019-09-25 15:58   ` Sironi, Filippo via iommu
2019-09-26  6:48   ` Jerry Snitselaar
2019-09-26  0:25 ` Jerry Snitselaar [this message]
2019-09-26  5:46   ` [PATCH 0/6] iommu/amd: Locking Fixes Joerg Roedel

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926002515.3xjm3fb6z42dfhar@cantor \
    --to=jsnitsel@redhat.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=sironi@amazon.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IOMMU Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iommu/0 linux-iommu/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iommu linux-iommu/ https://lore.kernel.org/linux-iommu \
		iommu@lists.linux-foundation.org
	public-inbox-index linux-iommu

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linux-foundation.lists.iommu


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git