From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11AE6C10F14 for ; Tue, 15 Oct 2019 11:40:50 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCEAF21928 for ; Tue, 15 Oct 2019 11:40:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCEAF21928 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A4059C9A; Tue, 15 Oct 2019 11:40:49 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 1BF97C97 for ; Tue, 15 Oct 2019 11:40:49 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id B607E5D3 for ; Tue, 15 Oct 2019 11:40:48 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id E6A532D9; Tue, 15 Oct 2019 13:40:46 +0200 (CEST) Date: Tue, 15 Oct 2019 13:40:45 +0200 From: Joerg Roedel To: Chris Wilson Subject: Re: [PATCH] iommu/intel: Use fallback generic_device_group() for ACPI devices Message-ID: <20191015114045.GJ14518@8bytes.org> References: <20191004205554.21055-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191004205554.21055-1-chris@chris-wilson.co.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Fri, Oct 04, 2019 at 09:55:54PM +0100, Chris Wilson wrote: > [ 2.073922] DMAR: ACPI device "INT33C2:00" under DMAR at fed91000 as 00:15.1 > [ 2.073983] DMAR: ACPI device "INT33C3:00" under DMAR at fed91000 as 00:15.2 > [ 2.074027] DMAR: ACPI device "INT33C0:00" under DMAR at fed91000 as 00:15.3 > [ 2.074072] DMAR: ACPI device "INT33C1:00" under DMAR at fed91000 as 00:15.4 I think just using generic_device_group() is not enough here. You need to mach the device-id of the ACPI device with the PCI hierarchy and find the right group there. You can look at the AMD IOMMU drivers acpihid_device_group() function for some inspiration. Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu