From: Joerg Roedel <joro@8bytes.org>
To: Adrian Huang <adrianhuang0701@gmail.com>
Cc: iommu@lists.linux-foundation.org, Adrian Huang <ahuang12@lenovo.com>
Subject: Re: [PATCH 1/1] iommu/amd: Fix the overwritten exclusion range with multiple IVMDs
Date: Mon, 11 Nov 2019 16:22:03 +0100 [thread overview]
Message-ID: <20191111152203.GJ18333@8bytes.org> (raw)
In-Reply-To: <20191104055852.24395-1-ahuang12@lenovo.com>
Hi Adrian,
On Mon, Nov 04, 2019 at 01:58:52PM +0800, Adrian Huang wrote:
> 2) When set_device_exclusion_range() parses the IVMD of devce id
> '4200', the exclusion range of the amd_iommu struct becomes:
>
> iommu->exclusion_start = 0x9F58D000;
> iommu->exclusion_length = 0x8040000;
>
> 3) When parsing the second IVMD (device id '4300') in
> set_device_exclusion_range(), the exclusion range of the
> amd_iommu struct becomes:
>
> iommu->exclusion_start = 0x9754D000;
> iommu->exclusion_length = 0x8040000;
>
> This overwrites the first IVMD configuration, which leads to
> the failure of the first RAID controller.
Okay, I think this is clearly a BIOS bug as the BIOS should not define
two different exclusion ranges in the IVRS table.
So there are a couple of options here:
1) Bail out and disable the IOMMU as the BIOS screwed up
2) Treat per-device exclusion ranges just as r/w unity-mapped
regions.
I think option 2) is the best fix here.
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-11-11 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 5:58 [PATCH 1/1] iommu/amd: Fix the overwritten exclusion range with multiple IVMDs Adrian Huang
2019-11-11 15:22 ` Joerg Roedel [this message]
2019-11-12 9:32 ` Huang Adrian
2019-11-12 16:05 ` Joerg Roedel
2019-11-13 1:05 ` Huang Adrian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111152203.GJ18333@8bytes.org \
--to=joro@8bytes.org \
--cc=adrianhuang0701@gmail.com \
--cc=ahuang12@lenovo.com \
--cc=iommu@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).