From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62732C432C0 for ; Wed, 20 Nov 2019 19:32:56 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 245292071F for ; Wed, 20 Nov 2019 19:32:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LxOhsLrB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 245292071F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id EFD3B27B79; Wed, 20 Nov 2019 19:32:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EMyLduMgIenj; Wed, 20 Nov 2019 19:32:53 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 56C3D2F923; Wed, 20 Nov 2019 19:32:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3999DC1DD8; Wed, 20 Nov 2019 19:32:35 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id E9660C18DA for ; Wed, 20 Nov 2019 19:32:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D133F888F1 for ; Wed, 20 Nov 2019 19:32:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hKbuWPmv1xXv for ; Wed, 20 Nov 2019 19:32:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id BB5C4888E9 for ; Wed, 20 Nov 2019 19:32:31 +0000 (UTC) Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03D4820715; Wed, 20 Nov 2019 19:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574278351; bh=b3qJemuygSOHQEtvC3bNqqipcwfplG1GcI0t5RyJZRM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=LxOhsLrBbDLVJAtnner/OZ/2C00+vtavCsvxNCt3t+fAKZVU3uNwWR8L/aaQgzoWx kdFgSoxeDUfJC5Dm8VfwclUN1ziMsoDX+T9BG808CeFORefSJUGgpAbPstk7MFTKzv NgtVq2R7IOmAVcnBd4wh7RsIcGr6xB1malqjBpv0= Date: Wed, 20 Nov 2019 13:32:28 -0600 From: Bjorn Helgaas To: Dmitry Safonov <0x7f454c46@gmail.com> Subject: Re: [PATCH] Ensure pci transactions coming from PLX NTB are handled when IOMMU is turned on Message-ID: <20191120193228.GA103670@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5c3b56dd-7088-e544-6628-01506f7b84e8@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Alex Williamson , Dmitry Safonov , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, Logan Gunthorpe X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" [+cc Alex] Hi James, Thanks for the patch, and thanks, Dmitry for the cc! "scripts/get_maintainer.pl -f drivers/pci/quirks.c" will give you a list of relevant email addresses to post patches. It was a good idea to augment that list with related addresses, e.g., Logan and the iommu list. Follow existing style for subject, e.g., PCI: Add DMA alias quirk for Microsemi Switchtec NTB for a recent similar patch. On Wed, Nov 20, 2019 at 05:48:45PM +0000, Dmitry Safonov wrote: > On 11/5/19 12:17 PM, James Sewart wrote: > >> On 24 Oct 2019, at 13:52, James Sewart wrote: > >> > >> The PLX PEX NTB forwards DMA transactions using Requester ID's that don't exist as > >> PCI devices. The devfn for a transaction is used as an index into a lookup table > >> storing the origin of a transaction on the other side of the bridge. > >> > >> This patch aliases all possible devfn's to the NTB device so that any transaction > >> coming in is governed by the mappings for the NTB. > >> > >> Signed-Off-By: James Sewart Conventionally capitalized as: Signed-off-by: James Sewart > >> --- > >> drivers/pci/quirks.c | 22 ++++++++++++++++++++++ > >> 1 file changed, 22 insertions(+) > >> > >> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > >> index 320255e5e8f8..647f546e427f 100644 > >> --- a/drivers/pci/quirks.c > >> +++ b/drivers/pci/quirks.c > >> @@ -5315,6 +5315,28 @@ SWITCHTEC_QUIRK(0x8574); /* PFXI 64XG3 */ > >> SWITCHTEC_QUIRK(0x8575); /* PFXI 80XG3 */ > >> SWITCHTEC_QUIRK(0x8576); /* PFXI 96XG3 */ > >> > >> +/* > >> + * PLX NTB uses devfn proxy IDs to move TLPs between NT endpoints. These IDs > >> + * are used to forward responses to the originator on the other side of the > >> + * NTB. Alias all possible IDs to the NTB to permit access when the IOMMU is > >> + * turned on. > >> + */ > >> +static void quirk_PLX_NTB_dma_alias(struct pci_dev *pdev) Conventional style is all lower-case (e.g. quirk_switchtec_ntb_dma_alias()) for function and variable names, and upper-case in English text. > >> +{ > >> + if (!pdev->dma_alias_mask) > >> + pdev->dma_alias_mask = kcalloc(BITS_TO_LONGS(U8_MAX), > >> + sizeof(long), GFP_KERNEL); > >> + if (!pdev->dma_alias_mask) { > >> + dev_warn(&pdev->dev, "Unable to allocate DMA alias mask\n"); pci_warn() > >> + return; > >> + } > >> + > >> + // PLX NTB may use all 256 devfns > >> + memset(pdev->dma_alias_mask, U8_MAX, (U8_MAX+1)/BITS_PER_BYTE); Use C (not C++) comment style, as the rest of the file does. I was about to suggest using pci_add_dma_alias(), but as currently implemented that would generate 256 messages in dmesg, which seems like overkill. But I think it would still be good to allocate the mask the same way (using bitmap_zalloc()) and to set the bits using bitmap_set(). It would also be nice to have one line in dmesg about these aliases, as a hint when debugging IOMMU faults. > >> +} > >> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_PLX, 0x87b0, quirk_PLX_NTB_dma_alias); > >> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_PLX, 0x87b1, quirk_PLX_NTB_dma_alias); > >> + > >> /* > >> * On Lenovo Thinkpad P50 SKUs with a Nvidia Quadro M1000M, the BIOS does > >> * not always reset the secondary Nvidia GPU between reboots if the system _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu