From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C607C43603 for ; Tue, 17 Dec 2019 10:18:09 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7F892072D for ; Tue, 17 Dec 2019 10:18:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7F892072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B41F786356; Tue, 17 Dec 2019 10:18:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8lgvV1SKym7z; Tue, 17 Dec 2019 10:18:08 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 1CAEE8633E; Tue, 17 Dec 2019 10:18:08 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id F03A8C1AE8; Tue, 17 Dec 2019 10:18:07 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 58284C077D for ; Tue, 17 Dec 2019 10:18:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4C5B6203F1 for ; Tue, 17 Dec 2019 10:18:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ORlsIkoCPawF for ; Tue, 17 Dec 2019 10:18:05 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by silver.osuosl.org (Postfix) with ESMTPS id F3C412001C for ; Tue, 17 Dec 2019 10:18:04 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 1B698286; Tue, 17 Dec 2019 11:18:02 +0100 (CET) Date: Tue, 17 Dec 2019 11:18:00 +0100 From: Joerg Roedel To: Christoph Hellwig Subject: Re: [PATCH v2] iommu/dma: Rationalise types for DMA masks Message-ID: <20191217101800.GL8689@8bytes.org> References: <00d1ddf9439a8c79fb561b0fc740bddf9e6fe6b1.1576089015.git.robin.murphy@arm.com> <20191211190235.GA17854@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191211190235.GA17854@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: arnd@arndb.de, stephan@gerhold.net, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, natechancellor@gmail.com, Robin Murphy , nsaenzjulienne@suse.de X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Dec 11, 2019 at 08:02:35PM +0100, Christoph Hellwig wrote: > On Wed, Dec 11, 2019 at 06:33:26PM +0000, Robin Murphy wrote: > > Since iommu_dma_alloc_iova() combines incoming masks with the u64 bus > > limit, it makes more sense to pass them around in their native u64 > > rather than converting to dma_addr_t early. Do that, and resolve the > > remaining type discrepancy against the domain geometry with a cheeky > > cast to keep things simple. > > > > Signed-off-by: Robin Murphy > > Looks good to me: > > Reviewed-by: Christoph Hellwig > > Joerg, let me know if you want to pick this up through the iommu tree as > it touches the iommu code, or through the dma-mapping tree that > introduced the warning. I'll take it through my tree, as I am about to collect fixes anyway. Patch is now applied, thanks everyone. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu