From: Christoph Hellwig <hch@infradead.org>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>
Cc: pratikp@codeaurora.org, linux-kernel@vger.kernel.org,
Liam Mark <lmark@codeaurora.org>,
iommu@lists.linux-foundation.org, kernel-team@android.com
Subject: Re: [RFC PATCH] iommu/iova: Add a best-fit algorithm
Date: Mon, 17 Feb 2020 00:03:39 -0800 [thread overview]
Message-ID: <20200217080339.GC10342@infradead.org> (raw)
In-Reply-To: <1581721602-17010-1-git-send-email-isaacm@codeaurora.org>
On Fri, Feb 14, 2020 at 03:06:42PM -0800, Isaac J. Manjarres wrote:
> From: Liam Mark <lmark@codeaurora.org>
>
> Using the best-fit algorithm, instead of the first-fit
> algorithm, may reduce fragmentation when allocating
> IOVAs.
As we like to say in standards groups: may also implies may not.
Please provide numbers showing that this helps, and preferably and
explanation how it doesn't hurt as well.
> + * Should be called prior to using dma-apis.
> + */
> +int iommu_dma_enable_best_fit_algo(struct device *dev)
> +{
> + struct iommu_domain *domain;
> + struct iova_domain *iovad;
> +
> + domain = iommu_get_domain_for_dev(dev);
> + if (!domain || !domain->iova_cookie)
> + return -EINVAL;
>
> + iovad = &((struct iommu_dma_cookie *)domain->iova_cookie)->iovad;
> + iovad->best_fit = true;
> return 0;
> }
> +EXPORT_SYMBOL(iommu_dma_enable_best_fit_algo);
Who is going to call this? Patches adding exports always need a user
that goes along with the export. Also drivers have no business calling
directly into dma-iommu.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-02-17 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 23:06 [RFC PATCH] iommu/iova: Add a best-fit algorithm Isaac J. Manjarres
2020-02-17 8:03 ` Christoph Hellwig [this message]
2020-02-17 16:03 ` Robin Murphy
2020-02-19 12:28 ` Will Deacon
2020-02-20 6:38 ` isaacm
2020-02-20 18:42 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217080339.GC10342@infradead.org \
--to=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=pratikp@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).