From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: aros@gmx.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH] device core: fix dma_mask handling in platform_device_register_full
Date: Wed, 11 Mar 2020 18:18:02 +0100 [thread overview]
Message-ID: <20200311171802.GA3952198@kroah.com> (raw)
In-Reply-To: <20200311161551.GA24878@lst.de>
On Wed, Mar 11, 2020 at 05:15:51PM +0100, Christoph Hellwig wrote:
> On Wed, Mar 11, 2020 at 05:14:23PM +0100, Greg KH wrote:
> > On Wed, Mar 11, 2020 at 05:07:10PM +0100, Christoph Hellwig wrote:
> > > Ever since the generic platform device code started allocating DMA masks
> > > itself the code to allocate and leak a private DMA mask in
> > > platform_device_register_full has been superflous. More so the fact that
> > > it unconditionally frees the DMA mask allocation in the failure path
> > > can lead to slab corruption if the function fails later on for a device
> > > where it didn't allocate the mask. Just remove the offending code.
> > >
> > > Fixes: cdfee5623290 ("driver core: initialize a default DMA mask for platform device")
> > > Reported-by: Artem S. Tashkinov <aros@gmx.com>
> > > Tested-by: Artem S. Tashkinov <aros@gmx.com>
> >
> > No s-o-b from you? :(
> >
> > I can take this, or Linus, you can take this now if you want to as well:
>
> Sorry, here it is:
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Is this still needed with the patch that Linus just committed to his
tree?
thanks,
greg k-h
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next parent reply other threads:[~2020-03-11 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200311160710.376090-1-hch@lst.de>
[not found] ` <20200311161423.GA3941932@kroah.com>
[not found] ` <20200311161551.GA24878@lst.de>
2020-03-11 17:18 ` Greg KH [this message]
2020-03-11 17:23 ` [PATCH] device core: fix dma_mask handling in platform_device_register_full Christoph Hellwig
2020-03-11 17:25 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311171802.GA3952198@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aros@gmx.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).