From: Joerg Roedel <joro@8bytes.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: kevin.tian@intel.com, ashok.raj@intel.com,
linux-kernel@vger.kernel.org, Daniel Drake <drake@endlessm.com>,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
Derrick Jonathan <jonathan.derrick@intel.com>
Subject: Re: [PATCH v2 2/6] iommu: Configure default domain with def_domain_type
Date: Thu, 19 Mar 2020 15:03:21 +0100 [thread overview]
Message-ID: <20200319140321.GA5122@8bytes.org> (raw)
In-Reply-To: <20200314010705.30711-3-baolu.lu@linux.intel.com>
Hi Baolu,
On Sat, Mar 14, 2020 at 09:07:01AM +0800, Lu Baolu wrote:
> +static int iommu_group_change_def_domain(struct iommu_group *group, int type)
> +{
> + struct group_device *grp_dev, *temp;
> + struct iommu_domain *new, *old;
> + const struct iommu_ops *ops;
> + int ret = 0;
> +
> + if ((type != IOMMU_DOMAIN_IDENTITY && type != IOMMU_DOMAIN_DMA) ||
> + !group->default_domain || type == group->default_domain->type ||
> + !group->default_domain->ops)
> + return -EINVAL;
> +
> + if (group->domain != group->default_domain)
> + return -EBUSY;
> +
> + iommu_group_ref_get(group);
> + old = group->default_domain;
> + ops = group->default_domain->ops;
> +
> + /* Allocate a new domain of requested type. */
> + new = ops->domain_alloc(type);
> + if (!new) {
> + ret = -ENOMEM;
> + goto domain_out;
> + }
> + new->type = type;
> + new->ops = ops;
> + new->pgsize_bitmap = group->default_domain->pgsize_bitmap;
> +
> + group->default_domain = new;
> + group->domain = new;
> + list_for_each_entry_safe(grp_dev, temp, &group->devices, list) {
> + struct device *dev;
> +
> + dev = grp_dev->dev;
> + if (device_is_bound(dev)) {
> + ret = -EINVAL;
> + goto device_out;
> + }
> +
> + iommu_group_create_direct_mappings(group, dev);
> + ret = __iommu_attach_device(group->domain, dev);
> + if (ret)
> + goto device_out;
In case of a failure here with a group containing multiple devices, the
other devices temporarily lose their mappings. Please only do the
device_is_bound() check in the loop and the actual re-attachment of the
group with a call to __iommu_attach_group().
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-03-19 14:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 1:06 [PATCH v2 0/6] Replace private domain with per-group default domain Lu Baolu
2020-03-14 1:07 ` [PATCH v2 1/6] iommu: Add def_domain_type() callback in iommu_ops Lu Baolu
2020-03-14 1:07 ` [PATCH v2 2/6] iommu: Configure default domain with def_domain_type Lu Baolu
2020-03-19 14:03 ` Joerg Roedel [this message]
2020-03-20 9:06 ` Lu Baolu
2020-03-14 1:07 ` [PATCH v2 3/6] iommu/vt-d: Don't force 32bit devices to uses DMA domain Lu Baolu
2020-03-14 1:07 ` [PATCH v2 4/6] iommu/vt-d: Don't force PCI sub-hierarchy to use " Lu Baolu
2020-03-14 1:07 ` [PATCH v2 5/6] iommu/vt-d: Add def_domain_type callback Lu Baolu
2020-03-14 1:07 ` [PATCH v2 6/6] iommu/vt-d: Apply per-device dma_ops Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319140321.GA5122@8bytes.org \
--to=joro@8bytes.org \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=drake@endlessm.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathan.derrick@intel.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).