IOMMU Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iommu: Lower severity of add/remove device messages
@ 2020-03-23 21:49 Ezequiel Garcia
  2020-03-27  9:50 ` Joerg Roedel
  0 siblings, 1 reply; 5+ messages in thread
From: Ezequiel Garcia @ 2020-03-23 21:49 UTC (permalink / raw)
  To: iommu; +Cc: kernel, Ezequiel Garcia, linux-kernel

These user messages are not really informational,
but mostly of debug nature. Lower their severity.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 drivers/iommu/iommu.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 3e3528436e0b..1ebd17033714 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -758,7 +758,7 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev)
 
 	trace_add_device_to_group(group->id, dev);
 
-	dev_info(dev, "Adding to iommu group %d\n", group->id);
+	dev_dbg(dev, "Adding to iommu group %d\n", group->id);
 
 	return 0;
 
@@ -792,7 +792,7 @@ void iommu_group_remove_device(struct device *dev)
 	struct iommu_group *group = dev->iommu_group;
 	struct group_device *tmp_device, *device = NULL;
 
-	dev_info(dev, "Removing from iommu group %d\n", group->id);
+	dev_dbg(dev, "Removing from iommu group %d\n", group->id);
 
 	/* Pre-notify listeners that a device is being removed. */
 	blocking_notifier_call_chain(&group->notifier,
@@ -2337,8 +2337,8 @@ request_default_domain_for_dev(struct device *dev, unsigned long type)
 
 	iommu_group_create_direct_mappings(group, dev);
 
-	dev_info(dev, "Using iommu %s mapping\n",
-		 type == IOMMU_DOMAIN_DMA ? "dma" : "direct");
+	dev_dbg(dev, "Using iommu %s mapping\n",
+		type == IOMMU_DOMAIN_DMA ? "dma" : "direct");
 
 	ret = 0;
 out:
-- 
2.26.0.rc2

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iommu: Lower severity of add/remove device messages
  2020-03-23 21:49 [PATCH] iommu: Lower severity of add/remove device messages Ezequiel Garcia
@ 2020-03-27  9:50 ` Joerg Roedel
  2020-03-27 13:02   ` Ezequiel Garcia
  0 siblings, 1 reply; 5+ messages in thread
From: Joerg Roedel @ 2020-03-27  9:50 UTC (permalink / raw)
  To: Ezequiel Garcia; +Cc: iommu, kernel, linux-kernel

On Mon, Mar 23, 2020 at 06:49:56PM -0300, Ezequiel Garcia wrote:
> These user messages are not really informational,
> but mostly of debug nature. Lower their severity.

Like most other messages in the kernel log, that is not a reason to
lower the severity. These messages are the first thing to look at when
looking into IOMMU related issues.

Regards,

	Joerg

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iommu: Lower severity of add/remove device messages
  2020-03-27  9:50 ` Joerg Roedel
@ 2020-03-27 13:02   ` Ezequiel Garcia
  2020-03-27 18:04     ` Robin Murphy
  0 siblings, 1 reply; 5+ messages in thread
From: Ezequiel Garcia @ 2020-03-27 13:02 UTC (permalink / raw)
  To: Joerg Roedel; +Cc: iommu, kernel, linux-kernel

Hello Joerg,

Thanks for reviewing.

I understand this change bears some controversy
for IOMMU, as developers are probably used to see these
messages.

On Fri, 2020-03-27 at 10:50 +0100, Joerg Roedel wrote:
> On Mon, Mar 23, 2020 at 06:49:56PM -0300, Ezequiel Garcia wrote:
> > These user messages are not really informational,
> > but mostly of debug nature. Lower their severity.
> 
> Like most other messages in the kernel log, that is not a reason to
> lower the severity.
>
> These messages are the first thing to look at when
> looking into IOMMU related issues.
> 

Sure, but the messages are still here, you can
always enable them when you are looking at IOMMU issues :-)

The idea is to reduce the amount of verbosity in the kernel.

If all subsystems would print messages that are useful
when looking at issues, things would be quite nasty verbose.

Thanks!
Ezequiel

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iommu: Lower severity of add/remove device messages
  2020-03-27 13:02   ` Ezequiel Garcia
@ 2020-03-27 18:04     ` Robin Murphy
  2020-03-27 22:25       ` Ezequiel Garcia
  0 siblings, 1 reply; 5+ messages in thread
From: Robin Murphy @ 2020-03-27 18:04 UTC (permalink / raw)
  To: Ezequiel Garcia, Joerg Roedel; +Cc: iommu, kernel, linux-kernel

On 2020-03-27 1:02 pm, Ezequiel Garcia wrote:
> Hello Joerg,
> 
> Thanks for reviewing.
> 
> I understand this change bears some controversy
> for IOMMU, as developers are probably used to see these
> messages.
> 
> On Fri, 2020-03-27 at 10:50 +0100, Joerg Roedel wrote:
>> On Mon, Mar 23, 2020 at 06:49:56PM -0300, Ezequiel Garcia wrote:
>>> These user messages are not really informational,
>>> but mostly of debug nature. Lower their severity.
>>
>> Like most other messages in the kernel log, that is not a reason to
>> lower the severity.
>>
>> These messages are the first thing to look at when
>> looking into IOMMU related issues.
>>
> 
> Sure, but the messages are still here, you can
> always enable them when you are looking at IOMMU issues :-)

That still begs the question of who "you" is and how they know they're 
debugging an IOMMU issue in the first place. When all the developer has 
to go on is a third-hand bugzilla attachment from a distro user's vague 
report of graphics corruption/poor I/O performance/boot 
failure/whatever, being able to tell straight away from a standard dmesg 
dump whether an IOMMU is even in the picture or not saves a lot of 
protracted back-and-forth for everyone involved.
> The idea is to reduce the amount of verbosity in the kernel.

Under what justification? Users with slow consoles or who just want a 
quiet boot are already free to turn down the loglevel; a handful of 
messages at boot-time and device hotplug seem hardly at risk of drowning 
out all the systemd audit spam anyway. Note that the IOMMU subsystem is 
by nature a little atypical as a lot of what it does is only visible as 
secondary effects on other drivers and subsystems, without their 
explicit involvement or knowledge. In that respect, hiding its activity 
can arguably lead to more non-obvious situations than many other subsystems.

> If all subsystems would print messages that are useful
> when looking at issues, things would be quite nasty verbose.

 From a personal standpoint, can we at least eradicate all the "Hi! I'm 
a driver/subsystem you don't even have the hardware for!" messages 
first, then maybe come back and reconsider the ones that convey actual 
information later?

Robin.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iommu: Lower severity of add/remove device messages
  2020-03-27 18:04     ` Robin Murphy
@ 2020-03-27 22:25       ` Ezequiel Garcia
  0 siblings, 0 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2020-03-27 22:25 UTC (permalink / raw)
  To: Robin Murphy, Joerg Roedel; +Cc: iommu, kernel, linux-kernel

On Fri, 2020-03-27 at 18:04 +0000, Robin Murphy wrote:
> On 2020-03-27 1:02 pm, Ezequiel Garcia wrote:
> > Hello Joerg,
> > 
> > Thanks for reviewing.
> > 
> > I understand this change bears some controversy
> > for IOMMU, as developers are probably used to see these
> > messages.
> > 
> > On Fri, 2020-03-27 at 10:50 +0100, Joerg Roedel wrote:
> > > On Mon, Mar 23, 2020 at 06:49:56PM -0300, Ezequiel Garcia wrote:
> > > > These user messages are not really informational,
> > > > but mostly of debug nature. Lower their severity.
> > > 
> > > Like most other messages in the kernel log, that is not a reason to
> > > lower the severity.
> > > 
> > > These messages are the first thing to look at when
> > > looking into IOMMU related issues.
> > > 
> > 
> > Sure, but the messages are still here, you can
> > always enable them when you are looking at IOMMU issues :-)
> 
> That still begs the question of who "you" is and how they know they're 
> debugging an IOMMU issue in the first place. When all the developer has 
> to go on is a third-hand bugzilla attachment from a distro user's vague 
> report of graphics corruption/poor I/O performance/boot 
> failure/whatever, being able to tell straight away from a standard dmesg 
> dump whether an IOMMU is even in the picture or not saves a lot of 
> protracted back-and-forth for everyone involved.
> > The idea is to reduce the amount of verbosity in the kernel.
> 
> Under what justification? Users with slow consoles or who just want a 
> quiet boot are already free to turn down the loglevel; a handful of 
> messages at boot-time and device hotplug seem hardly at risk of drowning 
> out all the systemd audit spam anyway. Note that the IOMMU subsystem is 
> by nature a little atypical as a lot of what it does is only visible as 
> secondary effects on other drivers and subsystems, without their 
> explicit involvement or knowledge. In that respect, hiding its activity 
> can arguably lead to more non-obvious situations than many other subsystems.
> 
> > If all subsystems would print messages that are useful
> > when looking at issues, things would be quite nasty verbose.
> 
>  From a personal standpoint, can we at least eradicate all the "Hi! I'm 
> a driver/subsystem you don't even have the hardware for!" messages 
> first, then maybe come back and reconsider the ones that convey actual 
> information later?
> 

Do we really still have those???

Thanks,
Ezequiel

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 21:49 [PATCH] iommu: Lower severity of add/remove device messages Ezequiel Garcia
2020-03-27  9:50 ` Joerg Roedel
2020-03-27 13:02   ` Ezequiel Garcia
2020-03-27 18:04     ` Robin Murphy
2020-03-27 22:25       ` Ezequiel Garcia

IOMMU Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iommu/0 linux-iommu/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iommu linux-iommu/ https://lore.kernel.org/linux-iommu \
		iommu@lists.linux-foundation.org
	public-inbox-index linux-iommu

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linux-foundation.lists.iommu


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git