From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF53C4332B for ; Mon, 23 Mar 2020 23:01:20 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA22220409 for ; Mon, 23 Mar 2020 23:01:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA22220409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id AA0C188157; Mon, 23 Mar 2020 23:01:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6T2bNYdobFCr; Mon, 23 Mar 2020 23:01:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id F24E788154; Mon, 23 Mar 2020 23:01:17 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D7A56C089F; Mon, 23 Mar 2020 23:01:17 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id B66B1C0177 for ; Mon, 23 Mar 2020 23:01:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9DFAF22D55 for ; Mon, 23 Mar 2020 23:01:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SgeBvAwfASvA for ; Mon, 23 Mar 2020 23:01:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by silver.osuosl.org (Postfix) with ESMTPS id 9987422730 for ; Mon, 23 Mar 2020 23:01:15 +0000 (UTC) IronPort-SDR: 1jIf30vDRsDt7KIPFVaEcGKiQdrSb0EDnyDtAHqXk2GVdOeMo4NKYOWTn8Ru0wHoOKhQXtK/cF jzfp9YBtmv9Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 16:01:13 -0700 IronPort-SDR: 63L9BKLoOyhbYTG1gj60ZxljqPCG74hvFUzHVqHYkdYLU2uVX8C/WpO6r95vZtLh5lf/rZhpu+ OBngCE5zvw1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,298,1580803200"; d="scan'208";a="419673469" Received: from otc-nc-03.jf.intel.com (HELO otc-nc-03) ([10.54.39.25]) by orsmga005.jf.intel.com with ESMTP; 23 Mar 2020 16:01:13 -0700 Date: Mon, 23 Mar 2020 16:01:13 -0700 From: "Raj, Ashok" To: Jean-Philippe Brucker Subject: Re: [PATCH 2/2] iommu/vt-d: Replace intel SVM APIs with generic SVA APIs Message-ID: <20200323230113.GA84386@otc-nc-03> References: <1582586797-61697-1-git-send-email-jacob.jun.pan@linux.intel.com> <1582586797-61697-4-git-send-email-jacob.jun.pan@linux.intel.com> <20200320092955.GA1702630@myrica> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200320092955.GA1702630@myrica> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: "Tian, Kevin" , Dave Jiang , Ashok Raj , Jean-Philippe Brucker , "Lu, Baolu" , LKML , iommu@lists.linux-foundation.org, David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Jean On Fri, Mar 20, 2020 at 10:29:55AM +0100, Jean-Philippe Brucker wrote: > > +#define to_intel_svm_dev(handle) container_of(handle, struct intel_svm_dev, sva) > > +struct iommu_sva * > > +intel_svm_bind(struct device *dev, struct mm_struct *mm, void *drvdata) > > +{ > > + struct iommu_sva *sva = ERR_PTR(-EINVAL); > > + struct intel_svm_dev *sdev = NULL; > > + int flags = 0; > > + int ret; > > + > > + /* > > + * TODO: Consolidate with generic iommu-sva bind after it is merged. > > + * It will require shared SVM data structures, i.e. combine io_mm > > + * and intel_svm etc. > > + */ > > + if (drvdata) > > + flags = *(int *)drvdata; > > drvdata is more for storing device driver contexts that can be passed to > iommu_sva_ops, but I get that this is temporary. > > As usual I'm dreading supervisor mode making it into the common API. What > are your plans regarding SUPERVISOR_MODE and PRIVATE_PASID flags? The > previous discussion on the subject [1] had me hoping that you could > replace supervisor mode with normal mappings (auxiliary domains?) > I'm less worried about PRIVATE_PASID, it would just add complexity into We don't seem to have an immediate need for PRIVATE_PASID. There are some talks about potential usages, but nothing concrete. I think it might be good to get rid of it now and add when we really need. For SUPERVISOR_MODE, the idea is to have aux domain. Baolu is working on something to replace. Certainly the entire kernel address is opening up the whole kimono.. so we are looking at dynamically creating mappings on demand. It might take some of the benefits of SVA in general with no need to create mappings, but for security somebody has to pay the price :-) Cheers, Ashok > the API and iommu-sva implementation, but doesn't really have security > implications. > > [1] https://lore.kernel.org/linux-iommu/20190228220449.GA12682@araj-mobl1.jf.intel.com/ _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu