From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
"Raj, Ashok" <ashok.raj@intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
LKML <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Alex Williamson <alex.williamson@redhat.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 1/3] iommu/uapi: Define uapi version and capabilities
Date: Fri, 27 Mar 2020 16:53:35 -0700 [thread overview]
Message-ID: <20200327165335.397f24a3@jacob-builder> (raw)
In-Reply-To: <20200327074702.GA27959@infradead.org>
On Fri, 27 Mar 2020 00:47:02 -0700
Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Mar 27, 2020 at 02:49:55AM +0000, Tian, Kevin wrote:
> > If those API calls are inter-dependent for composing a feature
> > (e.g. SVA), shouldn't we need a way to check them together before
> > exposing the feature to the guest, e.g. through a
> > iommu_get_uapi_capabilities interface?
>
> Yes, that makes sense. The important bit is to have a capability
> flags and not version numbers.
The challenge is that there are two consumers in the kernel for this.
1. VFIO only look for compatibility, and size of each data struct such
that it can copy_from_user.
2. IOMMU driver, the "real consumer" of the content.
For 2, I agree and we do plan to use the capability flags to check
content and maintain backward compatibility etc.
For VFIO, it is difficult to do size look up based on capability flags.
Jacob
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-03-27 23:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 23:17 [PATCH v2 0/3] IOMMU user API enhancement Jacob Pan
2020-03-25 23:17 ` [PATCH v2 1/3] iommu/uapi: Define uapi version and capabilities Jacob Pan
2020-03-26 9:23 ` Christoph Hellwig
2020-03-26 16:44 ` Jacob Pan
2020-03-27 2:49 ` Tian, Kevin
2020-03-27 7:47 ` Christoph Hellwig
2020-03-27 23:53 ` Jacob Pan [this message]
2020-03-30 5:40 ` Tian, Kevin
2020-03-30 16:07 ` Jacob Pan
2020-03-31 6:06 ` Tian, Kevin
2020-03-31 15:54 ` Jacob Pan
2020-04-01 5:32 ` Tian, Kevin
2020-04-02 18:36 ` Jacob Pan
2020-04-13 20:41 ` Jacob Pan
2020-04-13 22:21 ` Alex Williamson
2020-04-14 5:05 ` Jacob Pan
2020-04-14 16:13 ` Alex Williamson
2020-04-14 17:13 ` Jacob Pan
2020-04-14 22:32 ` Jacob Pan
2020-04-14 23:47 ` Tian, Kevin
2020-04-15 15:38 ` Jacob Pan
2020-04-16 1:27 ` Tian, Kevin
2020-04-14 8:15 ` Christoph Hellwig
2020-04-14 8:11 ` Christoph Hellwig
2020-04-14 16:06 ` Jacob Pan
2020-03-25 23:17 ` [PATCH v2 2/3] iommu/uapi: Use unified UAPI version Jacob Pan
2020-03-25 23:17 ` [PATCH v2 3/3] iommu/uapi: Add helper function for size lookup Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327165335.397f24a3@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).