Hi Hadar, Thank you for the patch! Yet something to improve: [auto build test ERROR on stm32/stm32-next] [also build test ERROR on linus/master v5.7-rc1 next-20200413] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200414-032638 base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next config: sparc-randconfig-a001-20200413 (attached as .config) compiler: sparc-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.3.0 make.cross ARCH=sparc If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): arch/sparc/mm/iommu.c: In function 'iommu_init': >> arch/sparc/mm/iommu.c:139:32: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration] 139 | struct platform_device *op = of_find_device_by_node(dp); | ^~~~~~~~~~~~~~~~~~~~~~ | bus_find_device_by_fwnode >> arch/sparc/mm/iommu.c:139:32: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] cc1: all warnings being treated as errors -- arch/sparc/mm/io-unit.c: In function 'iounit_init': >> arch/sparc/mm/io-unit.c:81:32: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration] 81 | struct platform_device *op = of_find_device_by_node(dp); | ^~~~~~~~~~~~~~~~~~~~~~ | bus_find_device_by_fwnode >> arch/sparc/mm/io-unit.c:81:32: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] cc1: all warnings being treated as errors vim +139 arch/sparc/mm/iommu.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 133 046e26a8ba10b8 David S. Miller 2008-08-27 134 static int __init iommu_init(void) 046e26a8ba10b8 David S. Miller 2008-08-27 135 { 046e26a8ba10b8 David S. Miller 2008-08-27 136 struct device_node *dp; 046e26a8ba10b8 David S. Miller 2008-08-27 137 046e26a8ba10b8 David S. Miller 2008-08-27 138 for_each_node_by_name(dp, "iommu") { cd4cd7306a403f Grant Likely 2010-07-22 @139 struct platform_device *op = of_find_device_by_node(dp); 046e26a8ba10b8 David S. Miller 2008-08-27 140 046e26a8ba10b8 David S. Miller 2008-08-27 141 sbus_iommu_init(op); 046e26a8ba10b8 David S. Miller 2008-08-27 142 of_propagate_archdata(op); 046e26a8ba10b8 David S. Miller 2008-08-27 143 } 046e26a8ba10b8 David S. Miller 2008-08-27 144 046e26a8ba10b8 David S. Miller 2008-08-27 145 return 0; 046e26a8ba10b8 David S. Miller 2008-08-27 146 } 046e26a8ba10b8 David S. Miller 2008-08-27 147 :::::: The code at line 139 was first introduced by commit :::::: cd4cd7306a403f62ef3ca783b9d1cf2a03e595ed sparc: remove references to of_device and to_of_device :::::: TO: Grant Likely :::::: CC: Grant Likely --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org