From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A74ECC54FCF for ; Mon, 20 Apr 2020 20:36:55 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74DB6206E9 for ; Mon, 20 Apr 2020 20:36:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74DB6206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 47EFC86303; Mon, 20 Apr 2020 20:36:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iaN9A7ipn76H; Mon, 20 Apr 2020 20:36:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 9CB6685B29; Mon, 20 Apr 2020 20:36:54 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 805A1C1D74; Mon, 20 Apr 2020 20:36:54 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 566AEC0177 for ; Mon, 20 Apr 2020 20:36:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4E2BB8785E for ; Mon, 20 Apr 2020 20:36:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oxLb-HmfkqNV for ; Mon, 20 Apr 2020 20:36:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id A045086130 for ; Mon, 20 Apr 2020 20:36:52 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id b13so9355332oti.3 for ; Mon, 20 Apr 2020 13:36:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0kqh5Q9Co3AbSPBrTmVcdN3oyZQj3KIAbrC9Aw9Jey8=; b=VpTHn/mT0z8QSnZoLE0r/1oSxd9LU9Z27aqylVzgiyZrn++LFAr47CVr/whZDQOSnC L808ss9Sq3tjzHTTrOWxZmOf4vBIhCUlD+CF2kLWIl1kuORH5+NzdmSD3EZpKLRAPiH2 XSLJzb2+smkgazMpog1HKi5qv/YrHgf5JF5zWsjft0iowPMzDjsKLkuXkWpbBk0kmo8T PpfBOLNn2jBzNlmm6ChACVXcs4MOTkeGHMEJJLZofbvuI4yl/8yIQCn9PAZ8cc4tYcN9 Z6Y2j42iTtrw/K0pIxOeRgojUQeYYslBp1BVkcIXSK2ogQwzcl6bet5W34ERYNX2KDpy SOLw== X-Gm-Message-State: AGi0Pub5WZnNl9ETqX1uW67E6c+Ys62dwUnDyvNgriEanB5ZHM9KxZsb iQ76vzk1xoLy5bOsKguZNg== X-Google-Smtp-Source: APiQypIKf0vB7yfwu8rT/KxQM+HvZK1R4I7Apur0UzYjSjNLrYCJKeDB/Ne3EnK+UZ4pWSPP25JeDQ== X-Received: by 2002:a9d:6a02:: with SMTP id g2mr11554009otn.196.1587415011744; Mon, 20 Apr 2020 13:36:51 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id r21sm190334otg.67.2020.04.20.13.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 13:36:50 -0700 (PDT) Received: (nullmailer pid 18971 invoked by uid 1000); Mon, 20 Apr 2020 20:36:47 -0000 Date: Mon, 20 Apr 2020 15:36:47 -0500 From: Rob Herring To: Hadar Gat Subject: Re: [PATCH] of_device: removed #include that caused a recursion in included headers Message-ID: <20200420203647.GA23189@bogus> References: <1586784960-22692-1-git-send-email-hadar.gat@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1586784960-22692-1-git-send-email-hadar.gat@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Jose Abreu , Alexandre Belloni , =?UTF-8?Q?Heiko_St=C3=BCbner?= , David Airlie , Linus Walleij , Liviu Dudau , dri-devel@lists.freedesktop.org, Sandy Huang , Thierry Reding , linux-mtd@lists.infradead.org, Miquel Raynal , netdev@vger.kernel.org, Kishon Vijay Abraham I , Lee Jones , linux-stm32@st-md-mailman.stormreply.com, Vignesh Raghavendra , linux-samsung-soc@vger.kernel.org, Frank Rowand , linux-rockchip@lists.infradead.org, Richard Weinberger , Vinod Koul , Krzysztof Kozlowski , Jonathan Hunter , Tony Lindgren , Ludovic Desroches , Andy Gross , devicetree@vger.kernel.org, Alexandre Torgue , linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, Maxime Ripard , Gilad Ben-Yossef , iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, Daniel Vetter , Chen-Yu Tsai , Sean Paul , linux-arm-kernel@lists.infradead.org, Ofir Drang , linux-gpio@vger.kernel.org, JC Kuo , Greg Kroah-Hartman , Giuseppe Cavallaro , Nicolas Ferre , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Kukjin Kim , Maxime Coquelin , Sudeep Holla , dmaengine@vger.kernel.org, freedreno@lists.freedesktop.org, "David S. Miller" , Jonathan Cameron X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Apr 13, 2020 at 04:35:53PM +0300, Hadar Gat wrote: > Both of_platform.h and of_device.h were included each other. > In of_device.h, removed unneeded #include to of_platform.h > and added include to of_platform.h in the files that needs it. Guess we forgot about that temporary comment! Both of these headers have a lot of things we don't want 'normal' drivers calling. The most common thing needed from of_device.h is of_match_device/of_device_get_match_data. A good number are only for ibmebus. Maybe the header should be split or the former just moved to of.h. For of_platform.h, it seems we have a bunch of unneeded includes: $ git grep 'of_platform\.h' drivers/ | wc 560 1120 36049 $ git grep -E 'of_(platform_(pop|def)|find_device)' drivers/ | wc 248 1215 20630 Would nice to drop those (or switch to of_device.h?) too. Be sure to build on Sparc. It's the oddball. > > Signed-off-by: Hadar Gat > --- > drivers/base/platform.c | 1 + > drivers/bus/vexpress-config.c | 1 + > drivers/dma/at_hdmac.c | 1 + > drivers/dma/stm32-dmamux.c | 1 + > drivers/dma/ti/dma-crossbar.c | 1 + > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 + > drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + > drivers/gpu/drm/msm/msm_drv.c | 1 + > drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 + > drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 + > drivers/iio/adc/stm32-adc-core.c | 1 + > drivers/iio/adc/stm32-dfsdm-adc.c | 1 + > drivers/iio/adc/stm32-dfsdm-core.c | 1 + > drivers/iommu/tegra-smmu.c | 1 + > drivers/memory/atmel-ebi.c | 1 + > drivers/mfd/palmas.c | 1 + > drivers/mfd/ssbi.c | 1 + > drivers/mtd/nand/raw/omap2.c | 1 + > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 + > drivers/net/ethernet/ti/cpsw.c | 1 + > drivers/phy/tegra/xusb.c | 1 + > drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 + > drivers/soc/samsung/exynos-pmu.c | 1 + > drivers/soc/sunxi/sunxi_sram.c | 1 + > include/linux/of_device.h | 2 -- > lib/genalloc.c | 1 + > 26 files changed, 25 insertions(+), 2 deletions(-) _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu