From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80823C2D0FA for ; Wed, 13 May 2020 08:42:59 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 587B420740 for ; Wed, 13 May 2020 08:42:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 587B420740 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 32C47869B8; Wed, 13 May 2020 08:42:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5n0Ux1Lu23pt; Wed, 13 May 2020 08:42:56 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 81ED28692B; Wed, 13 May 2020 08:42:56 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 49845C088B; Wed, 13 May 2020 08:42:56 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id E85AEC016F for ; Wed, 13 May 2020 08:42:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CF6F186978 for ; Wed, 13 May 2020 08:42:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O9hZCP-4j4lZ for ; Wed, 13 May 2020 08:42:53 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 7CB7D8692B for ; Wed, 13 May 2020 08:42:53 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 092FF379; Wed, 13 May 2020 10:42:51 +0200 (CEST) Date: Wed, 13 May 2020 10:42:50 +0200 From: Joerg Roedel To: Thierry Reding Subject: Re: [PATCH] iommu: Do not probe devices on IOMMU-less busses Message-ID: <20200513084250.GC9820@8bytes.org> References: <20200511161000.3853342-1-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511161000.3853342-1-thierry.reding@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org, Jon Hunter X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, May 11, 2020 at 06:10:00PM +0200, Thierry Reding wrote: > From: Thierry Reding > > The host1x bus implemented on Tegra SoCs is primarily an abstraction to > create logical device from multiple platform devices. Since the devices > in such a setup are typically hierarchical, DMA setup still needs to be > done so that DMA masks can be properly inherited, but we don't actually > want to attach the host1x logical devices to any IOMMU. The platform > devices that make up the logical device are responsible for memory bus > transactions, so it is them that will need to be attached to the IOMMU. > > Add a check to __iommu_probe_device() that aborts IOMMU setup early for > busses that don't have the IOMMU operations pointer set since they will > cause a crash otherwise. > > Signed-off-by: Thierry Reding > --- > Note that this is probably also required for the BCMA bus implemented in > drivers/bcma/main.c since no IOMMU operations are ever assigned to that > either. > > drivers/iommu/iommu.c | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu