From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC4BCA90AF for ; Wed, 13 May 2020 09:15:47 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF47520661 for ; Wed, 13 May 2020 09:15:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF47520661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9B2D520781; Wed, 13 May 2020 09:15:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dtmonzddVMto; Wed, 13 May 2020 09:15:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id AD40220385; Wed, 13 May 2020 09:15:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A7ACCC0178; Wed, 13 May 2020 09:15:43 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2C192C016F for ; Wed, 13 May 2020 09:15:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1B86B88699 for ; Wed, 13 May 2020 09:15:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5zZRsgPXDkQO for ; Wed, 13 May 2020 09:15:40 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2A67388687 for ; Wed, 13 May 2020 09:15:40 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id A4EB8379; Wed, 13 May 2020 11:15:38 +0200 (CEST) Date: Wed, 13 May 2020 11:15:37 +0200 From: Joerg Roedel To: Raul E Rangel Subject: Re: [PATCH v2] iommu/amd: Fix get_acpihid_device_id() Message-ID: <20200513091537.GJ9820@8bytes.org> References: <20200511103229.v2.1.I6f1b6f973ee6c8af1348611370c73a0ec0ea53f1@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200511103229.v2.1.I6f1b6f973ee6c8af1348611370c73a0ec0ea53f1@changeid> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Ulf Hansson , Joerg Roedel , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Andy Shevchenko , dianders@chromium.org, evgreen@chromium.org, Adrian Hunter , linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, Daniel Kurtz , Andy Shevchenko , Mika Westerberg X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, May 11, 2020 at 10:33:36AM -0600, Raul E Rangel wrote: > acpi_dev_hid_uid_match() expects a null pointer for UID if it doesn't > exist. The acpihid_map_entry contains a char buffer for holding the > UID. If no UID was provided in the IVRS table, this buffer will be > zeroed. If we pass in a null string, acpi_dev_hid_uid_match() will > return false because it will try and match an empty string to the ACPI > UID of the device. > > Fixes: ae5e6c6439c3 ("iommu/amd: Switch to use acpi_dev_hid_uid_match()") > Suggested-by: Andy Shevchenko > Signed-off-by: Raul E Rangel > Reviewed-by: Andy Shevchenko > --- > > Changes in v2: > - Added Suggested by > - Fixed commit description > - Decided to keep `p->uid[0]` instead of `*p->uid` since the data member is an array instead of a pointer. > - Used clang-format > > drivers/iommu/amd_iommu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied for v5.7, thanks Raul. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu