From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B716AC433DF for ; Fri, 15 May 2020 17:19:56 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75E87206D8 for ; Fri, 15 May 2020 17:19:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75E87206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 35F5722786; Fri, 15 May 2020 17:19:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NGxGXDgJNale; Fri, 15 May 2020 17:19:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 6390720446; Fri, 15 May 2020 17:19:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 58089C0859; Fri, 15 May 2020 17:19:51 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 50DA4C016F for ; Fri, 15 May 2020 17:19:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4C8B989B5F for ; Fri, 15 May 2020 17:19:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ap8Kifpapzei for ; Fri, 15 May 2020 17:19:49 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by hemlock.osuosl.org (Postfix) with ESMTPS id C48A089B4C for ; Fri, 15 May 2020 17:19:49 +0000 (UTC) IronPort-SDR: 75HL87wFeT6Bib2Zj5tIMIS26wC3fOfM5F1VZG/rqaMCUSn5+G2AFFALeBbSK3Vrb+4WVNsz0Z RJ/Az/ChmGvA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 10:19:49 -0700 IronPort-SDR: eZEoXLPhr5Cv4k9IWYM8gN4137BapxcAi4vssr/dR789L2+dXVQmk1JPIhPZN2nFL5mp2ML7hg BUSPg6BHnf6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,396,1583222400"; d="scan'208";a="281283658" Received: from otc-nc-03.jf.intel.com (HELO otc-nc-03) ([10.54.39.25]) by orsmga002.jf.intel.com with ESMTP; 15 May 2020 10:19:49 -0700 Date: Fri, 15 May 2020 10:19:49 -0700 From: "Raj, Ashok" To: Christoph Hellwig Subject: Re: [PATCH 0/4] PCI, iommu: Factor 'untrusted' check for ATS enablement Message-ID: <20200515171948.GC75440@otc-nc-03> References: <20200515104359.1178606-1-jean-philippe@linaro.org> <20200515154351.GA6546@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200515154351.GA6546@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: Jean-Philippe Brucker , Ashok Raj , linux-pci@vger.kernel.org, alex.williamson@redhat.com, iommu@lists.linux-foundation.org, bhelgaas@google.com, will@kernel.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Christoph On Fri, May 15, 2020 at 08:43:51AM -0700, Christoph Hellwig wrote: > Can you please lift the untrusted flag into struct device? It really > isn't a PCI specific concept, and we should not have code poking into > pci_dev all over the iommu code. Just for clarification: All IOMMU's today mostly pertain to only PCI devices and for devices that aren't PCI like HPET for instance we give a PCI identifier. Facilities like ATS for instance require the platform to have an IOMMU. what additional problems does moving this to struct device solve? Cheers, Ashok _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu