From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23269C433E1 for ; Mon, 1 Jun 2020 13:17:20 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E017D2074B for ; Mon, 1 Jun 2020 13:17:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S/JfOFba" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E017D2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B133086B9E; Mon, 1 Jun 2020 13:17:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ky34Dl6FNdzb; Mon, 1 Jun 2020 13:17:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 085A186B11; Mon, 1 Jun 2020 13:17:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DF26EC088D; Mon, 1 Jun 2020 13:17:17 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id AF345C088C for ; Mon, 1 Jun 2020 13:17:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id A438820119 for ; Mon, 1 Jun 2020 13:17:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9gvS69FI9Mev for ; Mon, 1 Jun 2020 13:17:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by silver.osuosl.org (Postfix) with ESMTPS id 22EE42002A for ; Mon, 1 Jun 2020 13:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591017432; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=bTjB8qfrHTSFjfUbutxvl/qwCsz3nerFRx3HPBX7A6Q=; b=S/JfOFbasRfNkNF9W59HtZI0O6axEa+LknXGz6r8HXoFLliGjE49Hh2h6eqA+X2J8PfOKG jgBzq+ZXHmBfvrN9nJFU2s9QExokmWR60k4p3IHPmlm97W5Bzb2ltqxZpra5aVKL8BXvkP rHnOyMuCHLRkjqInqgJ4efV23x+uYsw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-mKrpRIlFPeqUaxNJgU-KQg-1; Mon, 01 Jun 2020 09:17:06 -0400 X-MC-Unique: mKrpRIlFPeqUaxNJgU-KQg-1 Received: by mail-qv1-f69.google.com with SMTP id y2so2723179qvp.1 for ; Mon, 01 Jun 2020 06:17:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=bTjB8qfrHTSFjfUbutxvl/qwCsz3nerFRx3HPBX7A6Q=; b=aU+XCjdNOTC+EFenQzBSsSH1D7g9bMHkpXG5AcT17jP0m7O/dX6NSK/s1xrWgEFmzR /4NLcO3qgkPU2ltyjrS3dQZ65nu5E4jP5riXbP09pmu95OWXIloh3Osa4k64p6ZlcG2C fP8RamzWIk/ndLLx/MiYM/Fb9NmsG1N34EVqrjZZoH+YTQhtGfCuJB+6MEqSo5Er31px SczEKLtR+clSZVBCNdzPy7DLbdTF3Ko9oPSWPpTcFMpbp7VT2FPG391BbRuTiXEXm1sd 2izhj5gR6sQPu6eGob2XwrMcMOPzfAq31k0W171g6Y9TdfViUTxkDfK0xroeb1N5/hgu tfGg== X-Gm-Message-State: AOAM533IGnrfU3yTXxoRcZLxO/3Qhu9UoXbpCLSBixMDNEkf672QeiqF fWDqd9Y3HSDWthiw4d66gEwUIIGrsHvsN0DOujgviE2VhJWAI5iytErUTQrLwwg/foTyuEFRpEk g23iCgrAEjp1mZob/M2I2RjzdqPgquA== X-Received: by 2002:a0c:ee25:: with SMTP id l5mr20058563qvs.5.1591017425787; Mon, 01 Jun 2020 06:17:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfI03wn2xa5VbguB4ZgxB0Liv4dY32KsoEfpHfoc+ZEMln7Vo+khXJZaEY6bPHZ9c8b/Aysw== X-Received: by 2002:a0c:ee25:: with SMTP id l5mr20058438qvs.5.1591017424552; Mon, 01 Jun 2020 06:17:04 -0700 (PDT) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id r77sm12075150qke.6.2020.06.01.06.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 06:17:03 -0700 (PDT) Date: Mon, 1 Jun 2020 06:17:02 -0700 From: Jerry Snitselaar To: Joerg Roedel , Will Deacon , Robin Murphy , Marek Szyprowski , Kukjin Kim , Krzysztof Kozlowski , David Woodhouse , Lu Baolu , Andy Gross , Bjorn Andersson , Matthias Brugger , Rob Clark , Heiko Stuebner , Gerald Schaefer , Thierry Reding , Jonathan Hunter , Jean-Philippe Brucker , linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v2 00/33] iommu: Move iommu_group setup to IOMMU core code Message-ID: <20200601131702.4ksimsjvnsmo3mvn@cantor> Mail-Followup-To: Joerg Roedel , Will Deacon , Robin Murphy , Marek Szyprowski , Kukjin Kim , Krzysztof Kozlowski , David Woodhouse , Lu Baolu , Andy Gross , Bjorn Andersson , Matthias Brugger , Rob Clark , Heiko Stuebner , Gerald Schaefer , Thierry Reding , Jonathan Hunter , Jean-Philippe Brucker , linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org References: <20200414131542.25608-1-joro@8bytes.org> <20200529221623.qc6twmpzryh7nkvb@cantor> <20200601104240.7f5xhz7gooqhaq4n@cantor> MIME-Version: 1.0 In-Reply-To: <20200601104240.7f5xhz7gooqhaq4n@cantor> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jerry Snitselaar Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon Jun 01 20, Jerry Snitselaar wrote: >On Fri May 29 20, Jerry Snitselaar wrote: >>On Tue Apr 14 20, Joerg Roedel wrote: >>>Hi, >>> >>>here is the second version of this patch-set. The first version with >>>some more introductory text can be found here: >>> >>> https://lore.kernel.org/lkml/20200407183742.4344-1-joro@8bytes.org/ >>> >>>Changes v1->v2: >>> >>> * Rebased to v5.7-rc1 >>> >>> * Re-wrote the arm-smmu changes as suggested by Robin Murphy >>> >>> * Re-worked the Exynos patches to hopefully not break the >>> driver anymore >>> >>> * Fixed a missing mutex_unlock() reported by Marek Szyprowski, >>> thanks for that. >>> >>>There is also a git-branch available with these patches applied: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2 >>> >>>Please review. >>> >>>Thanks, >>> >>> Joerg >>> >>>Joerg Roedel (32): >>>iommu: Move default domain allocation to separate function >>>iommu/amd: Implement iommu_ops->def_domain_type call-back >>>iommu/vt-d: Wire up iommu_ops->def_domain_type >>>iommu/amd: Remove dma_mask check from check_device() >>>iommu/amd: Return -ENODEV in add_device when device is not handled by >>> IOMMU >>>iommu: Add probe_device() and remove_device() call-backs >>>iommu: Move default domain allocation to iommu_probe_device() >>>iommu: Keep a list of allocated groups in __iommu_probe_device() >>>iommu: Move new probe_device path to separate function >>>iommu: Split off default domain allocation from group assignment >>>iommu: Move iommu_group_create_direct_mappings() out of >>> iommu_group_add_device() >>>iommu: Export bus_iommu_probe() and make is safe for re-probing >>>iommu/amd: Remove dev_data->passthrough >>>iommu/amd: Convert to probe/release_device() call-backs >>>iommu/vt-d: Convert to probe/release_device() call-backs >>>iommu/arm-smmu: Convert to probe/release_device() call-backs >>>iommu/pamu: Convert to probe/release_device() call-backs >>>iommu/s390: Convert to probe/release_device() call-backs >>>iommu/virtio: Convert to probe/release_device() call-backs >>>iommu/msm: Convert to probe/release_device() call-backs >>>iommu/mediatek: Convert to probe/release_device() call-backs >>>iommu/mediatek-v1 Convert to probe/release_device() call-backs >>>iommu/qcom: Convert to probe/release_device() call-backs >>>iommu/rockchip: Convert to probe/release_device() call-backs >>>iommu/tegra: Convert to probe/release_device() call-backs >>>iommu/renesas: Convert to probe/release_device() call-backs >>>iommu/omap: Remove orphan_dev tracking >>>iommu/omap: Convert to probe/release_device() call-backs >>>iommu/exynos: Use first SYSMMU in controllers list for IOMMU core >>>iommu/exynos: Convert to probe/release_device() call-backs >>>iommu: Remove add_device()/remove_device() code-paths >>>iommu: Unexport iommu_group_get_for_dev() >>> >>>Sai Praneeth Prakhya (1): >>>iommu: Add def_domain_type() callback in iommu_ops >>> >>>drivers/iommu/amd_iommu.c | 97 ++++---- >>>drivers/iommu/amd_iommu_types.h | 1 - >>>drivers/iommu/arm-smmu-v3.c | 38 +-- >>>drivers/iommu/arm-smmu.c | 39 ++-- >>>drivers/iommu/exynos-iommu.c | 24 +- >>>drivers/iommu/fsl_pamu_domain.c | 22 +- >>>drivers/iommu/intel-iommu.c | 68 +----- >>>drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- >>>drivers/iommu/ipmmu-vmsa.c | 60 ++--- >>>drivers/iommu/msm_iommu.c | 34 +-- >>>drivers/iommu/mtk_iommu.c | 24 +- >>>drivers/iommu/mtk_iommu_v1.c | 50 ++-- >>>drivers/iommu/omap-iommu.c | 99 ++------ >>>drivers/iommu/qcom_iommu.c | 24 +- >>>drivers/iommu/rockchip-iommu.c | 26 +-- >>>drivers/iommu/s390-iommu.c | 22 +- >>>drivers/iommu/tegra-gart.c | 24 +- >>>drivers/iommu/tegra-smmu.c | 31 +-- >>>drivers/iommu/virtio-iommu.c | 41 +--- >>>include/linux/iommu.h | 21 +- >>>20 files changed, 533 insertions(+), 605 deletions(-) >>> >>>-- >>>2.17.1 >>> >>>_______________________________________________ >>>iommu mailing list >>>iommu@lists.linux-foundation.org >>>https://lists.linuxfoundation.org/mailman/listinfo/iommu >>> >> >>Hi Joerg, >> >>With this patchset, I have an epyc system where if I boot with >>iommu=nopt and force a dump I will see some io page faults for a nic >>on the system. The vmcore is harvested and the system reboots. I >>haven't reproduced it on other systems yet, but without the patchset I >>don't see the io page faults during the kdump. >> >>Regards, >>Jerry > >I just hit an issue on a separate intel based system (kdump iommu=nopt), >where it panics in during intel_iommu_attach_device, in is_aux_domain, >due to device_domain_info being DEFER_DEVICE_DOMAIN_INFO. That doesn't >get set to a valid address until the domain_add_dev_info call. > >Is it as simple as the following? > >diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c >index 29d3940847d3..f1bbeed46a4c 100644 >--- a/drivers/iommu/intel-iommu.c >+++ b/drivers/iommu/intel-iommu.c >@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) > { > struct device_domain_info *info = dev->archdata.iommu; >- return info && info->auxd_enabled && >- domain->type == IOMMU_DOMAIN_UNMANAGED; >+ return info && info != DEFER_DEVICE_DOMAIN_INFO && >+ info->auxd_enabled && domain->type == IOMMU_DOMAIN_UNMANAGED; > } > static void auxiliary_link_device(struct dmar_domain *domain, > > >Regards, >Jerry > With the patch, I avoid the panic, but I'm seeing an issue similar to the epyc system. I'm getting dmar faults from a couple of nics and the hp ilo. The addresses in question were in e820 reserved sections, but there aren't rmrr covering those addresses. The system manages to harvest the vmcore and reboot like the epyc. Without the patches I don't see the dmar faults. I needed to give this system back, but I'll try to poke at it some more in the next couple of days. Regards, Jerry _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu