From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: Improve exception handling in iommu_group_alloc()
Date: Tue, 2 Jun 2020 09:50:44 +0800 [thread overview]
Message-ID: <20200602015044.GA89266@VM20190228-100.tbsite.net> (raw)
In-Reply-To: <9f8d8308-2056-8e33-7b38-0b7d96e51c3c@web.de>
On Mon, Jun 01, 2020 at 02:38:05PM +0200, Markus Elfring wrote:
> > Optimize the error handling to free the resources correctly when
> > failed to allocate an iommu group.
>
> * I would not categorise the desired completion of exception handling
> as a software optimisation.
>
> * Would you like to add the tag “Fixes” to the commit message?
Sure.
>
> * I suggest to avoid the specification of duplicate function calls.
> Will it be helpful to add a few jump targets?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455
I don't think it is helpful or readable to add some jump targets here, since the exception handling is very simple here.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-06-02 1:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 12:38 [PATCH] iommu: Improve exception handling in iommu_group_alloc() Markus Elfring
2020-06-02 1:50 ` Baolin Wang [this message]
2020-06-02 5:01 ` Markus Elfring
2020-06-02 5:56 ` Baolin Wang
2020-06-02 7:06 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602015044.GA89266@VM20190228-100.tbsite.net \
--to=baolin.wang@linux.alibaba.com \
--cc=Markus.Elfring@web.de \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).