From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB596C433E0 for ; Thu, 18 Jun 2020 15:22:47 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60B202075E for ; Thu, 18 Jun 2020 15:22:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60B202075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0422F2269B; Thu, 18 Jun 2020 15:22:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gSoXWbdQ7Wiw; Thu, 18 Jun 2020 15:22:45 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 8BC8E203D3; Thu, 18 Jun 2020 15:22:45 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7CA7AC088C; Thu, 18 Jun 2020 15:22:45 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3B3C3C016E for ; Thu, 18 Jun 2020 15:22:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 22EC287EE9 for ; Thu, 18 Jun 2020 15:22:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1aoZ8FeATSXr for ; Thu, 18 Jun 2020 15:22:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by hemlock.osuosl.org (Postfix) with ESMTPS id 7BD6387EAE for ; Thu, 18 Jun 2020 15:22:43 +0000 (UTC) IronPort-SDR: k6u90w4ov4CHmZryNtjJI29havT8bd6RJxSccV7MOHSFqTOX5KpOxYgIRPyMB7X+ESWMvQuqRF FhnTMhxJ+tRQ== X-IronPort-AV: E=McAfee;i="6000,8403,9655"; a="140949084" X-IronPort-AV: E=Sophos;i="5.75,251,1589266800"; d="scan'208";a="140949084" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2020 08:22:42 -0700 IronPort-SDR: XgeIFWNm/rUPs3f8JBvzlSgZi/FudpaujhzTcJqwZYy14jIQfuwr/srpYtcNR3RxtTUZceiA85 vFX4SaXyTU2A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,251,1589266800"; d="scan'208";a="291802011" Received: from romley-ivt3.sc.intel.com ([172.25.110.60]) by orsmga002.jf.intel.com with ESMTP; 18 Jun 2020 08:22:41 -0700 Date: Thu, 18 Jun 2020 08:22:41 -0700 From: Fenghua Yu To: Christoph Hellwig Subject: Re: [PATCH v3 01/13] iommu: Change type of pasid to unsigned int Message-ID: <20200618152240.GD15763@romley-ivt3.sc.intel.com> References: <1592418233-17762-1-git-send-email-fenghua.yu@intel.com> <1592418233-17762-2-git-send-email-fenghua.yu@intel.com> <20200618071206.GA7294@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200618071206.GA7294@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Jean-Philippe Brucker , Tony Luck , Dave Jiang , Ashok Raj , Ravi V Shankar , Peter Zijlstra , x86 , linux-kernel , Dave Hansen , iommu@lists.linux-foundation.org, Ingo Molnar , Borislav Petkov , Jacob Jun Pan , H Peter Anvin , Christoph Hellwig , Thomas Gleixner , David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Jun 18, 2020 at 12:12:06AM -0700, Christoph Hellwig wrote: > On Wed, Jun 17, 2020 at 11:23:41AM -0700, Fenghua Yu wrote: > > PASID is defined as a few different types in iommu including "int", > > "u32", and "unsigned int". To be consistent and to match with ioasid's > > type, define PASID and its variations (e.g. max PASID) as "unsigned int". > > Wouldn't u32 be a little more explicit (besides being shorter and > matching the uapi definitions)? "unsigned int" matches ioasid_t type definition. Very (very) few places define pasid as "u32". If changing to u32, this patch will be much bigger. include/uapi/linux/iommu.h defines pasid as either __u32 or __u64. It's not just __u32. Thanks. -Fenghua _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu