From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC27C433DF for ; Mon, 22 Jun 2020 17:31:57 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2077E20656 for ; Mon, 22 Jun 2020 17:31:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2077E20656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id DE3DE88D5B; Mon, 22 Jun 2020 17:31:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id brtX078Yosvb; Mon, 22 Jun 2020 17:31:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id D48DB88C21; Mon, 22 Jun 2020 17:31:54 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B69E6C0891; Mon, 22 Jun 2020 17:31:54 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1F24AC016F for ; Mon, 22 Jun 2020 17:31:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 04D2720348 for ; Mon, 22 Jun 2020 17:31:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SdBWg4PG10-H for ; Mon, 22 Jun 2020 17:31:51 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by silver.osuosl.org (Postfix) with ESMTPS id 6A1DB20022 for ; Mon, 22 Jun 2020 17:31:51 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id CC32B68AEF; Mon, 22 Jun 2020 19:31:46 +0200 (CEST) Date: Mon, 22 Jun 2020 19:31:46 +0200 From: Christoph Hellwig To: Robin Murphy Subject: Re: [PATCH v2] dma-pool: Fix too large DMA pools on medium systems Message-ID: <20200622173146.GA15796@lst.de> References: <20200608132217.29945-1-geert@linux-m68k.org> <20200620200936.GA106151@roeck-us.net> <1287bffd-3363-0764-0309-32222b2b8c9a@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1287bffd-3363-0764-0309-32222b2b8c9a@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Linux Kernel Mailing List , Linux IOMMU , Geert Uytterhoeven , David Rientjes , Christoph Hellwig , Guenter Roeck X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Jun 22, 2020 at 05:07:55PM +0100, Robin Murphy wrote: > Another angle, though, is to question why this driver is making such a > large allocation with GFP_ATOMIC in the first place. At a glance it looks > like there's no reason at all other than that it's still using the legacy > pci_alloc_consistent() API, since every path to that appears to have > CAN_SLEEP passed as its flag - modernising that would arguably be an even > better long-term win. Maybe we can just try that for now? If other problems show up we can still increase the initial pool size later in this cycle. I'll try to cook up a patch. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu