From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rajat Jain <rajatja@google.com>
Cc: Todd Broch <tbroch@google.com>,
linux-pci <linux-pci@vger.kernel.org>,
"Krishnakumar,
Lalithambika" <lalithambika.krishnakumar@intel.com>,
Diego Rivas <diegorivas@google.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Furquan Shaikh <furquan@google.com>,
Raj Ashok <ashok.raj@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Christian Kellner <christian@kellner.me>,
Mattias Nissler <mnissler@google.com>,
Jesse Barnes <jsbarnes@google.com>, Len Brown <lenb@kernel.org>,
Rajat Jain <rajatxjain@gmail.com>,
Prashant Malani <pmalani@google.com>,
Aaron Durbin <adurbin@google.com>,
Alex Williamson <alex.williamson@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Bernie Keany <bernie.keany@intel.com>,
Duncan Laurie <dlaurie@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org,
Oliver O'Halloran <oohall@gmail.com>,
Benson Leung <bleung@google.com>,
David Woodhouse <dwmw2@infradead.org>,
Alex Levin <levinale@google.com>
Subject: Re: [PATCH 2/2] pci: Add parameter to disable attaching untrusted devices
Date: Sat, 27 Jun 2020 07:02:25 +0200 [thread overview]
Message-ID: <20200627050225.GA226238@kroah.com> (raw)
In-Reply-To: <CACK8Z6GSN5iOaCh-ZMaJSY4SgEhw=bCRDzaiPEBJbNNFhZZX6Q@mail.gmail.com>
On Fri, Jun 26, 2020 at 11:53:34AM -0700, Rajat Jain wrote:
> a) I think what was decided was introducing a device core "location"
> property that can be exposed to userspace to help it to decide whether
> or not to attach a driver to a device. Yes, that is still the plan.
Great, but this patch ignores that and starts to add policy :(
> (Mild sidenote: userspace may not need to distinguish between internal
> and external devices if it can assume that no internal PCI devices
> will show up after "echo 0 > /sys/bus/pci/drivers_autoprobe". But
> nevertheless...)
It can not assume that.
> b) Note that even with (a) in place, we still need a parameter that
> can ensure that drivers are not bound to external devices at boot,
> *before* userspace gets a chance to disable "drivers_autoprobe".
Why do you think you need that? I kind of doubt you really want this,
but ick, if you really do, make it a policy decision that you bake into
the kernel as a build option, so that no one else has to use it :)
> https://lkml.org/lkml/2020/6/15/1453
Ick, please use lore.kernel.org, we don't control lkml.org and it's not
all that reliable.
> Is it OK to add such a parameter in device core?
You don't have internal/external/wherever in the driver core yet, so
don't start adding policy before you get that...
thanks,
greg k-h
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-06-27 5:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 0:27 [PATCH 1/2] pci: Add pci device even if the driver failed to attach Rajat Jain via iommu
2020-06-26 0:27 ` [PATCH 2/2] pci: Add parameter to disable attaching untrusted devices Rajat Jain via iommu
2020-06-26 4:46 ` Greg Kroah-Hartman
2020-06-26 7:52 ` Oliver O'Halloran
2020-06-26 14:17 ` Greg Kroah-Hartman
2020-06-26 18:53 ` Rajat Jain via iommu
2020-06-27 5:02 ` Greg Kroah-Hartman [this message]
2020-06-26 14:14 ` [PATCH 1/2] pci: Add pci device even if the driver failed to attach Greg Kroah-Hartman
2020-06-26 15:39 ` Bjorn Helgaas
2020-06-26 19:01 ` Rajat Jain via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200627050225.GA226238@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adurbin@google.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=bernie.keany@intel.com \
--cc=bhelgaas@google.com \
--cc=bleung@google.com \
--cc=christian@kellner.me \
--cc=diegorivas@google.com \
--cc=dlaurie@google.com \
--cc=dwmw2@infradead.org \
--cc=furquan@google.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jsbarnes@google.com \
--cc=lalithambika.krishnakumar@intel.com \
--cc=lenb@kernel.org \
--cc=levinale@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mnissler@google.com \
--cc=oohall@gmail.com \
--cc=pmalani@google.com \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=tbroch@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).