From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95949C433E0 for ; Tue, 30 Jun 2020 09:49:59 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62AC7206A1 for ; Tue, 30 Jun 2020 09:49:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62AC7206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 340E687D98; Tue, 30 Jun 2020 09:49:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id An2gkShVeRe4; Tue, 30 Jun 2020 09:49:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 53E3987C52; Tue, 30 Jun 2020 09:49:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 21379C0865; Tue, 30 Jun 2020 09:49:58 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 87213C016E for ; Tue, 30 Jun 2020 09:49:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 688A722219 for ; Tue, 30 Jun 2020 09:49:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZvT1W2NyUcdI for ; Tue, 30 Jun 2020 09:49:53 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by silver.osuosl.org (Postfix) with ESMTPS id 474DE22001 for ; Tue, 30 Jun 2020 09:49:53 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 6B7FF26B; Tue, 30 Jun 2020 11:49:51 +0200 (CEST) Date: Tue, 30 Jun 2020 11:49:50 +0200 From: Joerg Roedel To: Jean-Philippe Brucker Subject: Re: [PATCH] iommu: Allow page responses without PASID Message-ID: <20200630094949.GG28824@8bytes.org> References: <20200616144712.748818-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200616144712.748818-1-jean-philippe@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Jun 16, 2020 at 04:47:14PM +0200, Jean-Philippe Brucker wrote: > Some PCIe devices do not expect a PASID value in PRI Page Responses. > If the "PRG Response PASID Required" bit in the PRI capability is zero, > then the OS should not set the PASID field. Similarly on Arm SMMU, > responses to stall events do not have a PASID. > > Currently iommu_page_response() systematically checks that the PASID in > the page response corresponds to the one in the page request. This can't > work with virtualization because a page response coming from a guest OS > won't have a PASID if the passed-through device does not require one. > > Add a flag to page requests that declares whether the corresponding > response needs to have a PASID. When this flag isn't set, allow page > responses without PASID. > > Reported-by: Shameerali Kolothum Thodi > Signed-off-by: Jean-Philippe Brucker > --- > include/uapi/linux/iommu.h | 6 +++++- > drivers/iommu/iommu.c | 23 +++++++++++++++++------ > 2 files changed, 22 insertions(+), 7 deletions(-) Applied, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu