From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF703C433DF for ; Tue, 30 Jun 2020 10:09:53 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6E9320771 for ; Tue, 30 Jun 2020 10:09:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6E9320771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 851278857C; Tue, 30 Jun 2020 10:09:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zb0pYSQNVBDl; Tue, 30 Jun 2020 10:09:53 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 29EDD8853D; Tue, 30 Jun 2020 10:09:53 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 157EBC0865; Tue, 30 Jun 2020 10:09:53 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1216FC016E for ; Tue, 30 Jun 2020 10:09:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 019BF8709F for ; Tue, 30 Jun 2020 10:09:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 45wpF_yPR0Dc for ; Tue, 30 Jun 2020 10:09:51 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 699CA87060 for ; Tue, 30 Jun 2020 10:09:51 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 88B422A7; Tue, 30 Jun 2020 12:09:49 +0200 (CEST) Date: Tue, 30 Jun 2020 12:09:48 +0200 From: Joerg Roedel To: Robin Murphy Subject: Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA Message-ID: <20200630100947.GL28824@8bytes.org> References: <20200629121146.24011-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, Geert Uytterhoeven , Maxime Ripard , linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Jun 29, 2020 at 05:29:36PM +0100, Robin Murphy wrote: > On 2020-06-29 13:11, Geert Uytterhoeven wrote: > > If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config): > > > > drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap': > > dma-iommu.c:(.text+0x92e): undefined reference to `dma_pgprot' > > > > IOMMU_DMA must not be selected, unless HAS_DMA=y. > > Wait, no, IOMMU_DMA should not be selected by drivers at all - it's for arch > code to choose. Okay, but that is a different fix, right? I queued this patch for v5.8 for now. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu