From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C51C433E3 for ; Wed, 22 Jul 2020 13:03:14 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D43420729 for ; Wed, 22 Jul 2020 13:03:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D43420729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2034188611; Wed, 22 Jul 2020 13:03:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4FB8wB83XNsw; Wed, 22 Jul 2020 13:03:13 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id A116E88612; Wed, 22 Jul 2020 13:03:13 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7B489C004E; Wed, 22 Jul 2020 13:03:13 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5FFACC004C for ; Wed, 22 Jul 2020 13:03:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 497D186190 for ; Wed, 22 Jul 2020 13:03:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UUpycFFfLYGQ for ; Wed, 22 Jul 2020 13:03:11 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 218E186166 for ; Wed, 22 Jul 2020 13:03:11 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id D81502C8; Wed, 22 Jul 2020 15:03:08 +0200 (CEST) Date: Wed, 22 Jul 2020 15:03:07 +0200 From: Joerg Roedel To: Colin King Subject: Re: [PATCH] OMAP: iommu: check for failure of a call to omap_iommu_dump_ctx Message-ID: <20200722130307.GC27672@8bytes.org> References: <20200714192211.744776-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200714192211.744776-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Tony Lindgren , kernel-janitors@vger.kernel.org, iommu@lists.linux-foundation.org, Hiroshi DOYU , linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Jul 14, 2020 at 08:22:11PM +0100, Colin King wrote: > From: Colin Ian King > > It is possible for the call to omap_iommu_dump_ctx to return > a negative error number, so check for the failure and return > the error number rather than pass the negative value to > simple_read_from_buffer. > > Addresses-Coverity: ("Improper use of negative value") > Fixes: 14e0e6796a0d ("OMAP: iommu: add initial debugfs support") > Signed-off-by: Colin Ian King > --- > drivers/iommu/omap-iommu-debug.c | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu